From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Jiabing Wan <wanjiabing@vivo.com>
Cc: "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Aric Cyr" <aric.cyr@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Wesley Chalmers" <Wesley.Chalmers@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Wayne Lin" <Wayne.Lin@amd.com>,
"Meenakshikumar Somasundaram"
<meenakshikumar.somasundaram@amd.com>,
"Chiawen Huang" <chiawen.huang@amd.com>,
"Anson Jacob" <Anson.Jacob@amd.com>,
"Alvin Lee" <alvin.lee2@amd.com>,
"Eric Yang" <Eric.Yang2@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kael_w@yeah.net
Subject: Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h
Date: Thu, 29 Apr 2021 10:41:21 -0400 [thread overview]
Message-ID: <20210429144121.v6ycsvwkk64s7grp@outlook.office365.com> (raw)
In-Reply-To: <AN*ARACWDmq3kx33Z4tCR4oU.3.1619698995121.Hmail.wanjiabing@vivo.com>
[-- Attachment #1: Type: text/plain, Size: 1751 bytes --]
Is your robot public available?
btw, applied to amd-staging-drm-next.
Thanks
On 04/29, Jiabing Wan wrote:
>
> >Nice catch!
> >
> >Are you using any tool to identify this problem?
>
> Yes, I have a robot including many detecting scripts :)
>
> >Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
> >
> >On 04/29, Wan Jiabing wrote:
> >> In commit 482812d56698e ("drm/amd/display: Set max TTU on
> >> DPG enable"), "hubp.h" was added which caused the duplicate include.
> >> To be on the safe side, remove the later duplicate include.
> >>
> >> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> >> ---
> >> drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> index 8f0a13807d05..dcaa6b1e16af 100644
> >> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> >> @@ -58,7 +58,6 @@
> >> #include "dc_link_ddc.h"
> >> #include "dm_helpers.h"
> >> #include "mem_input.h"
> >> -#include "hubp.h"
> >>
> >> #include "dc_link_dp.h"
> >> #include "dc_dmub_srv.h"
> >> --
> >> 2.25.1
> >>
> >
> >--
> >Rodrigo Siqueira
> >https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsiqueira.tech%2F&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Cb8ff161b3a904a49e59808d90b0991d9%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637552958013669698%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=I7AtEiOlzUuRQag7uAuArUvfd64l1b3gstq7ZTeucik%3D&reserved=0
>
> Yours,
> Wan Jiabing
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-04-29 14:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 3:04 Wan Jiabing
2021-04-29 12:05 ` Rodrigo Siqueira
2021-04-29 12:23 ` Jiabing Wan
2021-04-29 14:41 ` Rodrigo Siqueira [this message]
2021-04-29 15:18 ` Jiabing Wan
2021-04-29 15:21 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429144121.v6ycsvwkk64s7grp@outlook.office365.com \
--to=rodrigo.siqueira@amd.com \
--cc=Anson.Jacob@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Eric.Yang2@amd.com \
--cc=Wayne.Lin@amd.com \
--cc=Wesley.Chalmers@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=aric.cyr@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=chiawen.huang@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=sunpeng.li@amd.com \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®