From: Amey Narkhede <ameynarkhede03@gmail.com>
To: Ryder Lee <ryder.lee@mediatek.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Amey Narkhede <ameynarkhede03@gmail.com>
Subject: [PATCH v2] PCI: mediatek: Check return value of clk_prepare_enable
Date: Fri, 30 Apr 2021 21:24:29 +0530 [thread overview]
Message-ID: <20210430155429.35034-1-ameynarkhede03@gmail.com> (raw)
In case when free_ck clock is not enabled during device resume
check the return value of clk_prepare_enable() and return the
error after printing it.
Signed-off-by: Amey Narkhede <ameynarkhede03@gmail.com>
---
Changes in v2:
- Print the error before returning
- Clarify commit log
drivers/pci/controller/pcie-mediatek.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c
index 23548b517..9bdae34cc 100644
--- a/drivers/pci/controller/pcie-mediatek.c
+++ b/drivers/pci/controller/pcie-mediatek.c
@@ -1154,11 +1154,16 @@ static int __maybe_unused mtk_pcie_resume_noirq(struct device *dev)
{
struct mtk_pcie *pcie = dev_get_drvdata(dev);
struct mtk_pcie_port *port, *tmp;
+ int ret;
if (list_empty(&pcie->ports))
return 0;
- clk_prepare_enable(pcie->free_ck);
+ ret = clk_prepare_enable(pcie->free_ck);
+ if (ret) {
+ dev_err(dev, "Failed to enable free_ck clock\n");
+ return ret;
+ }
list_for_each_entry_safe(port, tmp, &pcie->ports, list)
mtk_pcie_enable_port(port);
--
2.31.1
reply other threads:[~2021-04-30 15:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210430155429.35034-1-ameynarkhede03@gmail.com \
--to=ameynarkhede03@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=ryder.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®