From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B2BC43461 for ; Sat, 1 May 2021 19:34:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 398DF61446 for ; Sat, 1 May 2021 19:34:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbhEATfU (ORCPT ); Sat, 1 May 2021 15:35:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231670AbhEATfO (ORCPT ); Sat, 1 May 2021 15:35:14 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83FBEC06174A for ; Sat, 1 May 2021 12:31:09 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id q136so1517721qka.7 for ; Sat, 01 May 2021 12:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5NGzqWvTvK589zokdLpymdCEmNc/llrSLUlZMFBA8FE=; b=Ex2dkyfLSkUIxknC8vMZhtwVIwpysg6mvT6d+W1OKohixIO2nWPUYPnQ/pf4GIJGyD 91/ZV7M7TA07tutqfh5YOhK4TUUk/F3UZa2idd4wPvNbntrnQDa1+5JBMpq8J1d61jsg ZWH+jNdFzxilepzIzYWfkjYYre1R+KZpuhJvDVa7Yjdw30wb2NkabyTawLLiCo5IgulB 9Rw9mi1FbE4eqiKjI2nBpTM0IDw8emXrqMJp82/wI4mrPJv24o1YbicvN9TA0FiFraDa W0XTXGTbg5cdI6mYSQX20WuWNudFBura5gCaJLDpnbBnRaZ+WncPyUe8vWU0XIMSwDyu 3sXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=5NGzqWvTvK589zokdLpymdCEmNc/llrSLUlZMFBA8FE=; b=lLHIbsM1X80+7HCp3jT/HrATrwahshhuAqt65cV+macDvseAScPwOwSFYOCgdjQbiJ yVgTiR2eo7Mfbh1FUmPw+bLqm4r+xN6as1ckxoe2Sjn0mrkNp6/z9Y6ek12Vp6mDaHZ/ fW+8guQISvtXbubXjXmHs9FGihWJGPCW9F7je2gOKKT35F7oLtE6LBuMKDVNkp/VD9ay yUR9pqofx3lzWCYModsymwHKu7LWea0sMBWPNVHW5ANazs62iU3SBq2cCvsok+ljamMl Szfi+fF6yebhvQGoVMguuveGBrNoMjwXrdldAlWYid3/iQ4OmgIL6kCeEJGC6spJro3N nexg== X-Gm-Message-State: AOAM531S6Im/vFkzwtMtjwoPne9i4O3ElW/9AUd9hLRUlaKTb5ulQ5VZ PjqfgywXEITYpYXkJgALDtw= X-Google-Smtp-Source: ABdhPJymwcM2yWO75sXaqDFZmVXg/3JLoR3K63CxFSdw7O3AAiD+yc3GrI1G/rvrGUvlMMNXV0BeCA== X-Received: by 2002:a05:620a:133b:: with SMTP id p27mr4757886qkj.354.1619897468692; Sat, 01 May 2021 12:31:08 -0700 (PDT) Received: from localhost.localdomain ([2804:431:cfcf:9b0e:2d21:2696:6c86:a623]) by smtp.gmail.com with ESMTPSA id y23sm4690352qkb.47.2021.05.01.12.31.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 May 2021 12:31:08 -0700 (PDT) From: Thais Camacho To: Johan Hovold , Alex Elder , Greg Kroah-Hartman Cc: Thais Camacho , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] Staging: greybus: tools: loopback_test: fixed coding style issues Date: Sat, 1 May 2021 16:30:42 -0300 Message-Id: <20210501193043.12153-1-thaiscamachoo@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixed warnings found by checkpatch.pl script Signed-off-by: Thais Camacho --- drivers/staging/greybus/tools/loopback_test.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/staging/greybus/tools/loopback_test.c b/drivers/staging/greybus/tools/loopback_test.c index 867bf289df2e..553883b2bfa3 100644 --- a/drivers/staging/greybus/tools/loopback_test.c +++ b/drivers/staging/greybus/tools/loopback_test.c @@ -239,7 +239,6 @@ static void show_loopback_devices(struct loopback_test *t) for (i = 0; i < t->device_count; i++) printf("device[%d] = %s\n", i, t->devices[i].name); - } int open_sysfs(const char *sys_pfx, const char *node, int flags) @@ -274,7 +273,6 @@ float read_sysfs_float_fd(int fd, const char *sys_pfx, const char *node) char buf[SYSFS_MAX_INT]; if (read(fd, buf, sizeof(buf)) < 0) { - fprintf(stderr, "unable to read from %s%s %s\n", sys_pfx, node, strerror(errno)); close(fd); @@ -367,7 +365,6 @@ static int get_results(struct loopback_test *t) r->apbridge_unipro_latency_max - r->apbridge_unipro_latency_min; r->gbphy_firmware_latency_jitter = r->gbphy_firmware_latency_max - r->gbphy_firmware_latency_min; - } /*calculate the aggregate results of all enabled devices */ @@ -407,7 +404,6 @@ static int get_results(struct loopback_test *t) r->apbridge_unipro_latency_max - r->apbridge_unipro_latency_min; r->gbphy_firmware_latency_jitter = r->gbphy_firmware_latency_max - r->gbphy_firmware_latency_min; - } return 0; @@ -536,7 +532,6 @@ static int log_results(struct loopback_test *t) fprintf(stderr, "unable to open %s for appendation\n", file_name); abort(); } - } for (i = 0; i < t->device_count; i++) { if (!device_enabled(t, i)) @@ -550,10 +545,8 @@ static int log_results(struct loopback_test *t) if (ret == -1) fprintf(stderr, "unable to write %d bytes to csv.\n", len); } - } - if (t->aggregate_output) { len = format_output(t, &t->aggregate_results, "aggregate", data, sizeof(data), &tm); @@ -675,11 +668,13 @@ static int open_poll_files(struct loopback_test *t) static int close_poll_files(struct loopback_test *t) { int i; + for (i = 0; i < t->poll_count; i++) close(t->fds[i].fd); return 0; } + static int is_complete(struct loopback_test *t) { int iteration_count; @@ -740,7 +735,6 @@ static int wait_for_complete(struct loopback_test *t) ts = &t->poll_timeout; while (1) { - ret = ppoll(t->fds, t->poll_count, ts, &mask_old); if (ret <= 0) { stop_tests(t); @@ -780,7 +774,6 @@ static void prepare_devices(struct loopback_test *t) if (t->stop_all || device_enabled(t, i)) write_sysfs_val(t->devices[i].sysfs_entry, "type", 0); - for (i = 0; i < t->device_count; i++) { if (!device_enabled(t, i)) continue; @@ -823,13 +816,12 @@ static int start(struct loopback_test *t) return 0; } - void loopback_run(struct loopback_test *t) { int i; int ret; - for (i = 0; dict[i].name != NULL; i++) { + for (i = 0; dict[i].name; i++) { if (strstr(dict[i].name, t->test_name)) t->test_id = dict[i].type; } @@ -852,7 +844,6 @@ void loopback_run(struct loopback_test *t) if (ret) goto err; - get_results(t); log_results(t); @@ -861,7 +852,6 @@ void loopback_run(struct loopback_test *t) err: printf("Error running test\n"); - return; } static int sanity_check(struct loopback_test *t) @@ -881,10 +871,8 @@ static int sanity_check(struct loopback_test *t) fprintf(stderr, "Bad device mask %x\n", (1 << i)); return -1; } - } - return 0; } -- 2.20.1