From: Guenter Roeck <linux@roeck-us.net>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
linux-watchdog@vger.kernel.org, kernel@pengutronix.de,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API
Date: Mon, 3 May 2021 08:28:54 -0700 [thread overview]
Message-ID: <20210503152854.GA624769@roeck-us.net> (raw)
In-Reply-To: <9f326f40-08dd-ab2b-0a80-970d20c57d6a@pengutronix.de>
On Mon, May 03, 2021 at 04:39:25PM +0200, Ahmad Fatoum wrote:
> Hello Guenter,
>
> On 03.05.21 16:31, Guenter Roeck wrote:
> >> -static struct fintek_wdt watchdog = {
> >> - .lock = __MUTEX_INITIALIZER(watchdog.lock),
> >> -};
> >> +static struct fintek_wdt watchdog;
> >
> > This should really be allocated, and "watchdog" is a terrible variable name
> > even if static, especially given the previous patch.
>
> I can add a follow up patch to change this. I maintained the old
> state of things here to make review easier.
>
Odd argument. You changed all the function names (unnecessarily,
if you ask me) in the first patch of the series because they were
too generic in your opinion. That by itself added a lot of unnecessary
complexity to the review. And pretty much everything else changed
in this patch anyway.
Guenter
next prev parent reply other threads:[~2021-05-03 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 10:46 [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 1/3] watchdog: f71808e_wdt: rename variant-independent identifiers appropriately Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 2/3] watchdog: f71808e_wdt: migrate to new kernel watchdog API Ahmad Fatoum
2021-05-03 14:31 ` Guenter Roeck
2021-05-03 14:39 ` Ahmad Fatoum
2021-05-03 15:28 ` Guenter Roeck [this message]
2021-05-03 18:33 ` Ahmad Fatoum
2021-04-13 10:46 ` [RESEND PATCH v3 3/3] watchdog: f71808e_wdt: refactor to platform device/driver pair Ahmad Fatoum
2021-05-03 13:09 ` [RESEND PATCH v3 0/3] watchdog: f71808e_wdt: migrate to new kernel API Marc Kleine-Budde
2021-05-03 13:33 ` Guenter Roeck
2021-05-03 13:49 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210503152854.GA624769@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.fatoum@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®