mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	Cao jin <jojing64@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	Ingo Molnar <mingo@kernel.org>, Qiujun Huang <hqjagain@gmail.com>,
	Wan Jiabing <wanjiabing@vivo.com>, Xu Wang <vulab@iscas.ac.cn>,
	"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: Re: [ GIT PULL] tracing: Updates for 5.13
Date: Mon, 3 May 2021 16:03:35 -0400	[thread overview]
Message-ID: <20210503160335.3f3be2f2@gandalf.local.home> (raw)
In-Reply-To: <CAHk-=wgo40oeh3huHvb64KfeNEYXw_hQXLXqujbhYz18TMZ6ZA@mail.gmail.com>

On Mon, 3 May 2021 11:27:02 -0700
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > This is the first time I'm sending a pull request with a merge
> > in it. I'm hoping my scripts did everything correctly. Might want
> > to check it a bit more than usual.  
> 
> The merge looks fine. It causes the diffstat to show incorrectly,
> which is normal (and generally avoided by you doing a test merge so
> that you get the diffstat from the merged state - but don't send the
> merge itself to me, just use it to (a) look at what conflicts there
> will be and (b) get that correct diffstat for the end result).

OK, makes sense.

> 
> That said, if the only reason for the merge was one single trivial
> commit, you could just have cherry-picked it instead, avoiding the
> things like "oh, now it has two merge bases so 'diff' no longer has an
> unambiguous result" etc.

I was thinking of doing the simple cherry-pick, but I wanted to test if
merges would work too, as I'm hoping that I can start pulling from others
someday, and not just take patches. I figured I'd try on a trivial merge
to see what breaks.

> 
> But this is fine. If you start doing a lot of merges, I may really ask
> you to then also do that test-merge for the pull request, but if it's

Good to know. If I start pulling more complex merges, I'll do the test
merge for the diffstat then.

Thanks,

-- Steve

      reply	other threads:[~2021-05-03 20:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-03 13:17 Steven Rostedt
2021-05-03 18:27 ` Linus Torvalds
2021-05-03 20:03   ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210503160335.3f3be2f2@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=colin.king@canonical.com \
    --cc=hqjagain@gmail.com \
    --cc=jojing64@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=unixbhaskar@gmail.com \
    --cc=vulab@iscas.ac.cn \
    --cc=wanjiabing@vivo.com \
    --cc=y.karadz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®