From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B08CEC43460 for ; Mon, 3 May 2021 22:57:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 79664613B3 for ; Mon, 3 May 2021 22:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbhECW6E (ORCPT ); Mon, 3 May 2021 18:58:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbhECW6B (ORCPT ); Mon, 3 May 2021 18:58:01 -0400 Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 856E2C061761 for ; Mon, 3 May 2021 15:57:07 -0700 (PDT) Received: by mail-qk1-x729.google.com with SMTP id q136so6845586qka.7 for ; Mon, 03 May 2021 15:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=ouRSQEEjT38vBUuV862SeUlllVCT6eH9A/DLELLKUUCUzA1ShVzuWVXQ1MBHwfUp52 o2iY2zmGF5v6LzhQq+GBDBerKVAePtFNVbGHvM38jkoESd9bfzmAI5TW5EmfL78E08Qn KIGOFGei7/yO8yCpBYVzXmS09DZEEm+pTY6CGCqEpqr9/YKTEYQHHgmnMtxfiJhxhwEM PI6Kaqk2dLQBbp3lySC34PVTv8PJZyC4fg+IILviuxHg1B8L5kSFMxjKrsIeWCcV13AT K2K+mR+5wr9SajVl5e5SOe9bFPiH9IuQFOm4a7VNUrSG+YlFkkc7yhkY+MYykwPRCxJe dU1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xZZm+3MFuedFCkj1MfVgDeM954nHR/3fXds6exXmQfs=; b=asDwcFE2YU8vcb1DESqoKIJUWd9xXScfsKZd4Le/b1LxJmyug3gKx+6h5n7kTpyNM9 rPi9aVWO2d4UOkU9pxrMcXffzxjkbnNr8N/pwC9MXacvCLT9YQfLQqTr1qFxqISjsJSt M2e5XsDtWJ6ZEdV8N2UReadaaOrrKZ7CTaIQlN7NI/fPvWt/m0vrnUeDCDewihODnX7o eWksArNbURceJdfA+KL6e1gwvnkjb1yW/c6Lw4F5/oPyCSFCWtvqMHLN4A9dEJnIFMmX v/xCX6GHuddVIy7vxy1M1YQx5FXvqWXg9tMeNETKOP1SKhzD6B3RZwb67ehq19dFj4B5 4ngw== X-Gm-Message-State: AOAM53246qDEdziA8ohGEIsYQooKoiT0UAeWp1q1oSozbb2adt2n07ll GdyqGpM9DbLwfuZIA6eHpuzeaCiPfZhYgAsH X-Google-Smtp-Source: ABdhPJwB6nytiC0oDMbKJRBwSIes/jqgsePpJ+MXFQRNiesNGamVx4ATl+XqEZHAz4GA6Yzrb48bvQ== X-Received: by 2002:a37:a9c8:: with SMTP id s191mr6160737qke.430.1620082626750; Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from ziepe.ca ([206.223.160.26]) by smtp.gmail.com with ESMTPSA id c17sm897865qtd.71.2021.05.03.15.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 15:57:06 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1ldhUv-00H3QZ-2z; Mon, 03 May 2021 19:57:05 -0300 Date: Mon, 3 May 2021 19:57:05 -0300 From: Jason Gunthorpe To: John Hubbard Cc: Logan Gunthorpe , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-pci@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Stephen Bates , Christoph Hellwig , Dan Williams , Christian =?utf-8?B?S8O2bmln?= , Don Dutile , Matthew Wilcox , Daniel Vetter , Jakowski Andrzej , Minturn Dave B , Jason Ekstrand , Dave Hansen , Xiong Jianxin , Bjorn Helgaas , Ira Weiny , Robin Murphy Subject: Re: [PATCH 04/16] PCI/P2PDMA: Refactor pci_p2pdma_map_type() to take pagmap and device Message-ID: <20210503225705.GA2047089@ziepe.ca> References: <20210408170123.8788-1-logang@deltatee.com> <20210408170123.8788-5-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 03, 2021 at 02:54:26PM -0700, John Hubbard wrote: > I guess my main concern here is that there are these pci*() functions > that somehow want to pass around struct device. Well, this is the main issue - helpers being used inside IOMMU code should not be called pci* functions. This is some generic device p2p interface that happens to only support PCI to PCI transfers today. Jason