mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: Jessica Yu <jeyu@kernel.org>, linux-kernel@vger.kernel.org
Cc: Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 4/4] module: reduce already_uses pr_debug verbosity
Date: Wed,  5 May 2021 22:00:19 -0600	[thread overview]
Message-ID: <20210506040019.1322778-5-jim.cromie@gmail.com> (raw)
In-Reply-To: <20210506040019.1322778-1-jim.cromie@gmail.com>

already_uses() is unnecessarily chatty.  For example,
`modprobe i915` yields 491 messages like:

  [   64.108744] i915 uses drm!

This is a normal situation, and isn't worth all the log entries.  The
!found pr_debug is kept, its more of an exceptional condition, and
seems worth a pr_debug.  I haven't seen it happen.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 kernel/module.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/kernel/module.c b/kernel/module.c
index c3333b45d812..dc1eda39ba96 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -772,10 +772,8 @@ static int already_uses(struct module *a, struct module *b)
 	struct module_use *use;
 
 	list_for_each_entry(use, &b->source_list, source_list) {
-		if (use->source == a) {
-			pr_debug("%s uses %s!\n", a->name, b->name);
+		if (use->source == a)
 			return 1;
-		}
 	}
 	pr_debug("%s does not use %s!\n", a->name, b->name);
 	return 0;
-- 
2.30.2


      parent reply	other threads:[~2021-05-06  4:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210506040019.1322778-1-jim.cromie@gmail.com>
2021-05-06  4:00 ` [PATCH 1/4] module: add modname being loaded to pr_debugs Jim Cromie
2021-05-06  4:00 ` [PATCH 2/4] module: add symbol-name to pr_debug Absolute symbol Jim Cromie
2021-05-06  4:00 ` [PATCH 3/4] module: add section-size to move_module pr_debug Jim Cromie
2021-05-06  4:00 ` Jim Cromie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506040019.1322778-5-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®