From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F713C433B4 for ; Thu, 6 May 2021 18:19:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 540606103E for ; Thu, 6 May 2021 18:19:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233791AbhEFSUT (ORCPT ); Thu, 6 May 2021 14:20:19 -0400 Received: from sender4-of-o53.zoho.com ([136.143.188.53]:21313 "EHLO sender4-of-o53.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhEFSUS (ORCPT ); Thu, 6 May 2021 14:20:18 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1620325155; cv=none; d=zohomail.com; s=zohoarc; b=KXH6ODj9YZy7EfbkPcfjkM+XlsXfwz397wyKPn9GPHskq/9XSgXxLvskAh7b3IuNp5BqWQEkoF4I/t7OL+TlxVlcjilx9Th88F6LdlJcmd7EXPsfUviIf7YrfWwz2tGzUMflzUguq7t0hRs/0vJgNAKEzCVoqfzUKT+kEpdKPmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1620325155; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=6DDF2B6OrMM0QxGNsdtFui4c6DfEyuwe9HcAxJ1ve7M=; b=PUCjhE+eFwCtUUjTN/rtTnyQ7FxPmXF7d/N+lNlmfryd8L5Jz2fNcMzSKaH4LV3zqYG34co5g0OqIjw7MjZb4Gyw6h8+rvIs6HTEu6sfLXtX9P3/i9KvGr5X/Ive84FOM0z2p9UYvdAd7sbFvub8wgxwZO9vLCs8dPgurutCBNQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=anirudhrb.com; spf=pass smtp.mailfrom=mail@anirudhrb.com; dmarc=pass header.from= header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1620325155; s=zoho; d=anirudhrb.com; i=mail@anirudhrb.com; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=6DDF2B6OrMM0QxGNsdtFui4c6DfEyuwe9HcAxJ1ve7M=; b=MIDzm1rtNT6eSuKiaT8tBDlIfhXPuM2GqIjk3hiech6UoIkTP7VFnfw6AdbgKkqm QuXqS72qjniH5CaWVJmQYOLE1rf/dcd5rB5veGYyM5hoo07JdqhjTq/t2JCIEPvtcxE BXHZBpyY/2TR/2tCoUmHJLZhWsoPKgDyQS9kq8y8= Received: from localhost.localdomain (49.207.210.243 [49.207.210.243]) by mx.zohomail.com with SMTPS id 1620325151474625.7325176070485; Thu, 6 May 2021 11:19:11 -0700 (PDT) From: Anirudh Rayabharam To: Matt Porter , Alexandre Bounine Cc: gregkh@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, Anirudh Rayabharam , linux-kernel@vger.kernel.org Subject: [PATCH v2] rapidio: fix unused variable warning in rio_cm.c Date: Thu, 6 May 2021 23:48:36 +0530 Message-Id: <20210506181837.4758-1-mail@anirudhrb.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GCC produces an unused variable warning for 'rc': drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’: drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but not used [-Wunused-but-set-variable] The return value of rio_add_outb_message() is assigned to 'rc' but it is never used. Fix this warning by logging an error if 'rc' is non-zero. Signed-off-by: Anirudh Rayabharam --- Changes in v2: Log an error instead of just removing 'rc'. v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/ --- drivers/rapidio/rio_cm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c index 50ec53d67a4c..971a36f1a23a 100644 --- a/drivers/rapidio/rio_cm.c +++ b/drivers/rapidio/rio_cm.c @@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot) cm->tx_buf[cm->tx_slot] = req->buffer; rc = rio_add_outb_message(cm->mport, req->rdev, cmbox, req->buffer, req->len); + if (rc) { + riocm_error("Failed to add msg to tx queue (err=%d)", + rc); + } + kfree(req->buffer); kfree(req); -- 2.26.2