From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C57EAC433B4 for ; Thu, 6 May 2021 19:13:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CFEF6113E for ; Thu, 6 May 2021 19:13:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234954AbhEFTOv (ORCPT ); Thu, 6 May 2021 15:14:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:40144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234467AbhEFTOu (ORCPT ); Thu, 6 May 2021 15:14:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 63B3C61107; Thu, 6 May 2021 19:13:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620328431; bh=Xd/ndCtgZJ2dO4cS5u02uHTb6AeNYHoi+rl86LUAbso=; h=From:To:Cc:Subject:Date:From; b=GYgkzkyezQq25+wnQeXre7srZxxQyVeHIWgdt+aJ9BwHucvGsxj8IqBFxcABjkdyf fTSQFXtZHhvZeevvP/MtiPeAZS7gaZK/9Hw2zF5fSRcQmrNLVYUs2w7hBeWQcNvDV6 699A6NY5iSs56tuPkLBWjPVv/ikWYjzSIyrlTQEMsedhHv1sS8KAGlaDS3zOx6FB0J AurGdOsFF+ZI332T8HAT4lt4Wjn5INvv/eR8PDtB8yc3odCV0EuSuLP+HkZE+v6Z4O 6mp9SKlDDkUVOM8EMd2Kv+8bvhef2RN6t/afdelMtddteKTSjucLS5ojIpNr4Fjaz3 q8qiVhYbYmA7A== From: Jaegeuk Kim To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim Subject: [PATCH] f2fs: return -EPERM given generic mask Date: Thu, 6 May 2021 12:13:47 -0700 Message-Id: <20210506191347.1242802-1-jaegeuk@kernel.org> X-Mailer: git-send-email 2.31.1.607.g51e8a6a459-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In f2fs_fileattr_set(), if (!fa->flags_valid) mask &= FS_COMMON_FL; In this case, we should not allow to set FS_COMPR_FL, instead of BUG_ON. /* Flags shared betwen flags/xflags */ (FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \ FS_NODUMP_FL | FS_NOATIME_FL | FS_DAX_FL | \ FS_PROJINHERIT_FL) Fixes: 4c5b47997521 ("vfs: add fileattr ops") Signed-off-by: Jaegeuk Kim --- fs/f2fs/file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index e01ce802cf10..38015ef84893 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1817,7 +1817,9 @@ static int f2fs_setflags_common(struct inode *inode, u32 iflags, u32 mask) struct f2fs_inode_info *fi = F2FS_I(inode); u32 masked_flags = fi->i_flags & mask; - f2fs_bug_on(F2FS_I_SB(inode), (iflags & ~mask)); + /* mask can be shrunk by flags_valid selector */ + if (iflags & ~mask) + return -EPERM; /* Is it quota file? Do not allow user to mess with it */ if (IS_NOQUOTA(inode)) -- 2.31.1.607.g51e8a6a459-goog