From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36C91C433ED for ; Fri, 7 May 2021 13:16:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC33761466 for ; Fri, 7 May 2021 13:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233655AbhEGNRa (ORCPT ); Fri, 7 May 2021 09:17:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:46352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbhEGNR1 (ORCPT ); Fri, 7 May 2021 09:17:27 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E5AB61468; Fri, 7 May 2021 13:16:27 +0000 (UTC) Date: Fri, 7 May 2021 09:16:25 -0400 From: Steven Rostedt To: Jiapeng Chong Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] tracing: Remove redundant assignment to event_var Message-ID: <20210507091625.0bcccf43@gandalf.local.home> In-Reply-To: <1620383030-70462-1-git-send-email-jiapeng.chong@linux.alibaba.com> References: <1620383030-70462-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 7 May 2021 18:23:50 +0800 Jiapeng Chong wrote: > Variable event_var is set to 'ERR_PTR(-EINVAL)', but this value > is never read as it is overwritten or not used later on, hence > it is a redundant assignment and can be removed. > > Clean up the following clang-analyzer warning: > > kernel/trace/trace_events_hist.c:2437:21: warning: Value stored to > 'event_var' during its initialization is never read > [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > kernel/trace/trace_events_hist.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c > index c1abd63..b37342c 100644 > --- a/kernel/trace/trace_events_hist.c > +++ b/kernel/trace/trace_events_hist.c > @@ -2434,7 +2434,7 @@ static struct trace_event_file *event_file(struct trace_array *tr, > char *subsys_name, char *event_name, char *field_name) > { > struct trace_array *tr = target_hist_data->event_file->tr; > - struct hist_field *event_var = ERR_PTR(-EINVAL); > + struct hist_field *event_var; > struct hist_trigger_data *hist_data; > unsigned int i, n, first = true; > struct field_var_hist *var_hist; Thanks, but if you are going to make this change, please move the declaration of event_var below (or above) key_field, as their names are both the same size in length and are of the same type. This keeps the "upside-down x-mas tree" look of the declarations. -- Steve