From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3545EC433B4 for ; Mon, 10 May 2021 04:46:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 013C361424 for ; Mon, 10 May 2021 04:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230049AbhEJErM (ORCPT ); Mon, 10 May 2021 00:47:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:46968 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbhEJErI (ORCPT ); Mon, 10 May 2021 00:47:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E47D613CE; Mon, 10 May 2021 04:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1620621964; bh=rp7Pr5ZwLz7xf26y8soMdGC8+zpjFeP6bya6HohveU8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=CqyexdQOXdYJurd8t44gilCxJyd/22uk3uYbXEYUkNJt1aSbnwkCuFEt6rLVjHaFQ ZtJ0VcZ4E1eih/esEpLdf/IQYyVMLueE6B2tv+RKF3LqRezylSovsacOdKMbEPZ4YL P9NiKYAR7R7YOj1GRmmDexSjy73xHqOshwnt2G+4= Date: Sun, 9 May 2021 21:46:03 -0700 From: Andrew Morton To: glittao@gmail.com Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm/slub: use stackdepot to save stack trace in objects Message-Id: <20210509214603.d2a5faaa3fe0d71c3517cb36@linux-foundation.org> In-Reply-To: <20210414163434.4376-1-glittao@gmail.com> References: <20210414163434.4376-1-glittao@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Apr 2021 18:34:34 +0200 glittao@gmail.com wrote: > Many stack traces are similar so there are many similar arrays. > Stackdepot saves each unique stack only once. > > Replace field addrs in struct track with depot_stack_handle_t handle. > Use stackdepot to save stack trace. > > The benefits are smaller memory overhead and possibility to aggregate > per-cache statistics in the future using the stackdepot handle > instead of matching stacks manually. Which tree was this prepared against? 5.12's kmem_obj_info() is significantly different from the version you were working on. Please take a look, redo, retest and resend? Thanks.