From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B965EC433ED for ; Tue, 11 May 2021 21:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DCCC6190A for ; Tue, 11 May 2021 21:06:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbhEKVHS (ORCPT ); Tue, 11 May 2021 17:07:18 -0400 Received: from elvis.franken.de ([193.175.24.41]:50447 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229637AbhEKVHN (ORCPT ); Tue, 11 May 2021 17:07:13 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1lgZZt-00041V-00; Tue, 11 May 2021 23:06:05 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 3884EC0E42; Tue, 11 May 2021 23:03:49 +0200 (CEST) Date: Tue, 11 May 2021 23:03:49 +0200 From: Thomas Bogendoerfer To: bibo mao Cc: Anshuman Khandual , Andrew Morton , Mike Kravetz , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] hugetlb: clear huge pte during flush function on mips platform Message-ID: <20210511210349.GA18846@alpha.franken.de> References: <1593436533-8645-1-git-send-email-maobibo@loongson.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1593436533-8645-1-git-send-email-maobibo@loongson.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 29, 2020 at 09:15:32PM +0800, bibo mao wrote: > From: Bibo Mao > > If multiple threads are accessing the same huge page at the same > time, hugetlb_cow will be called if one thread write the COW huge > page. And function huge_ptep_clear_flush is called to notify other > threads to clear the huge pte tlb entry. The other threads clear > the huge pte tlb entry and reload it from page table, the reload > huge pte entry may be old. > > This patch fixes this issue on mips platform, and it clears huge > pte entry before notifying other threads to flush current huge > page entry, it is similar with other architectures. > > Signed-off-by: Bibo Mao > --- > arch/mips/include/asm/hugetlb.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]