From: Masami Hiramatsu <mhiramat@kernel.org>
To: Zou Wei <zou_wei@huawei.com>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>,
<hayashi.kunihiko@socionext.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -next] regulator: uniphier: Add missing MODULE_DEVICE_TABLE
Date: Wed, 12 May 2021 10:40:15 +0900 [thread overview]
Message-ID: <20210512104015.e6536460f9b584d7bd3c7284@kernel.org> (raw)
In-Reply-To: <1620705198-104566-1-git-send-email-zou_wei@huawei.com>
On Tue, 11 May 2021 11:53:18 +0800
Zou Wei <zou_wei@huawei.com> wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
Looks good to me.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thank you!
> ---
> drivers/regulator/uniphier-regulator.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/uniphier-regulator.c b/drivers/regulator/uniphier-regulator.c
> index 2e02e26..e75b097 100644
> --- a/drivers/regulator/uniphier-regulator.c
> +++ b/drivers/regulator/uniphier-regulator.c
> @@ -201,6 +201,7 @@ static const struct of_device_id uniphier_regulator_match[] = {
> },
> { /* Sentinel */ },
> };
> +MODULE_DEVICE_TABLE(of, uniphier_regulator_match);
>
> static struct platform_driver uniphier_regulator_driver = {
> .probe = uniphier_regulator_probe,
> --
> 2.6.2
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2021-05-12 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 3:53 Zou Wei
2021-05-11 18:21 ` Mark Brown
2021-05-12 1:40 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512104015.e6536460f9b584d7bd3c7284@kernel.org \
--to=mhiramat@kernel.org \
--cc=broonie@kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®