From: Alan Stern <stern@rowland.harvard.edu>
To: chris.chiu@canonical.com
Cc: gregkh@linuxfoundation.org, m.v.b@runbox.com, hadess@hadess.net,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub"
Date: Thu, 13 May 2021 10:40:18 -0400 [thread overview]
Message-ID: <20210513144018.GE967812@rowland.harvard.edu> (raw)
In-Reply-To: <20210513041446.3082-3-chris.chiu@canonical.com>
On Thu, May 13, 2021 at 12:14:46PM +0800, chris.chiu@canonical.com wrote:
> From: Chris Chiu <chris.chiu@canonical.com>
>
> This reverts commit ca91fd8c7643d93bfc18a6fec1a0d3972a46a18a. The
Use the proper format for referring to commits: just the first 12 hex
digits of the commit ID, followed by the commit's name in parentheses
and quotation marks. See other patch submissions in the mailing list
archives for examples.
> problematic hub should be taken care for each setting PORT_SUSPEND
> feature timeout instead of reset-resume all the time.
The last sentence is not grammatical. It should say something more
like:
The previous patch in this series now handles problematic hubs
by checking the port status when a PORT_SUSPEND timeout occurs,
so we don't need to use reset-resume all the time.
Alan Stern
>
> Signed-off-by: Chris Chiu <chris.chiu@canonical.com>
> ---
> drivers/usb/core/quirks.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 21e7522655ac..6114cf83bb44 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -406,7 +406,6 @@ static const struct usb_device_id usb_quirk_list[] = {
>
> /* Realtek hub in Dell WD19 (Type-C) */
> { USB_DEVICE(0x0bda, 0x0487), .driver_info = USB_QUIRK_NO_LPM },
> - { USB_DEVICE(0x0bda, 0x5487), .driver_info = USB_QUIRK_RESET_RESUME },
>
> /* Generic RTL8153 based ethernet adapters */
> { USB_DEVICE(0x0bda, 0x8153), .driver_info = USB_QUIRK_NO_LPM },
> --
> 2.20.1
>
prev parent reply other threads:[~2021-05-13 14:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 4:14 [PATCH v3 0/2] USB: propose a generic fix for PORT_SUSPEND set feature timeout chris.chiu
2021-05-13 4:14 ` [PATCH v3 1/2] USB: Verify the port status when timeout happens during port suspend chris.chiu
2021-05-13 14:35 ` Alan Stern
2021-05-13 4:14 ` [PATCH v3 2/2] Revert "USB: Add reset-resume quirk for WD19's Realtek Hub" chris.chiu
2021-05-13 14:40 ` Alan Stern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513144018.GE967812@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=chris.chiu@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.v.b@runbox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®