From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B0DC433ED for ; Fri, 14 May 2021 09:31:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE159611BD for ; Fri, 14 May 2021 09:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233736AbhENJcu (ORCPT ); Fri, 14 May 2021 05:32:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230440AbhENJct (ORCPT ); Fri, 14 May 2021 05:32:49 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EEFBC061574 for ; Fri, 14 May 2021 02:31:37 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id l1so7772815ejb.6 for ; Fri, 14 May 2021 02:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HvoBw86ctVXyhbWOgqr0xC6pEc+fFV76B2CUFf5kjSI=; b=ixbflPe1nhsPohr943bOZRN0CJ+ifoIo0TDjt48YRc4xHRRCPSrahZoEgrS5nzfzZb PONow1l+ujnBhdNyMHuqJQdz3N84k2ah+t7CE1DVLjfjuYw5mCU8B0M7IYfl8rg1qju1 HssrGdLLzIgvXR4bt6VHeZwvddqLLcwh6Pa3ruvgWHL8/jS21QDK/SGqXypD4053Gsmp gBJ4E8glAaO98vKkkOIwyrpwQPZ7/Iu/ao0s1VInzy/sVRFTDgXrwK1ByT/uUpjAiCxY u4Jt2w3dijAU++3Z1mptel+cC6+WWwvGOcJ074K275VTqlnC1P3/ipsYgYafCu8FXHsL DYVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=HvoBw86ctVXyhbWOgqr0xC6pEc+fFV76B2CUFf5kjSI=; b=nUxO1tVMUvyR+uc+JxvvzN65wkN5s5v4/E4gaIhHNKZeZgsZTKpHXTyO5shrHleu9i kxYnfb9F1hPyLEla2DGOaZRoRLt2p5FPpPCyjDkjW+aTG2mLz35LI9s7xGrpEWqi78IM XbtvsR86dhEoleVuY8fJkQW323CVVyQGfO/t/PKWbSR3u7GG3vdOn/pgrxpqEn019uRP faHGoCtbO89f/pOp7W19Ai1pgWQlMeU87EICiGtwy0kBOjqF04LkMacRCFy7nlcgjBsj zOb8XlHpZ0X9T/QkjAKsmb2cunxyTy5BxBKevKG28OX6QvIk5nmEfr3nseN8UfKzZis5 Q9Rw== X-Gm-Message-State: AOAM533fO6BnlCr1Gb02Ey1Ld9GVc0P89sVyjLpI7w/EL0qY3SagvOjk slURMKIwB7czYuOFHFgGFPo= X-Google-Smtp-Source: ABdhPJyMMG/8Kf6iC2x/uQf7CA6SwYK6+F8q8EGAG4/wT5mAAZPcB0VU/MD/prGUZ6iseHDub9Lu+A== X-Received: by 2002:a17:906:c1ca:: with SMTP id bw10mr20705685ejb.512.1620984695970; Fri, 14 May 2021 02:31:35 -0700 (PDT) Received: from agape.jhs ([5.171.81.81]) by smtp.gmail.com with ESMTPSA id o20sm4047302eds.20.2021.05.14.02.31.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 May 2021 02:31:35 -0700 (PDT) Date: Fri, 14 May 2021 11:31:20 +0200 From: Fabio Aiuto To: Hans de Goede Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, youling 257 , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: staging: rtl8723bs: questions on TODO list Message-ID: <20210514093119.GB13800@agape.jhs> References: <20210514083856.GA13800@agape.jhs> <85289dbc-e986-9beb-f7d6-eca9e8750c8a@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <85289dbc-e986-9beb-f7d6-eca9e8750c8a@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 14, 2021 at 11:15:42AM +0200, Hans de Goede wrote: > Hi Fabio, > > On 5/14/21 10:38 AM, Fabio Aiuto wrote: > > Hello all, > > > > I'd like to have some clarifications about rtl8723bs driver. > > In order to make this driver ready for moving out of staging > > I would like to know: > > > > - find and remove remaining code valid only for 5 GHz. Most of the obvious > > ones have been removed, but things like channel > 14 still exist. > > > > is it possible to remove all 5g code, even the one related to power > > regulation when on band 5g? As far as I know about this card is that > > it doesn't support 5g, so may I just delete all 5g code or there are some > > constraints I'd take care of? > > These cards are 2.4G only so any code of which you are sure it is for > 5G only can be removed. > > > - find and remove any code for other chips that is left over > > > > Ok this seems clear, are there some suggestion to do it safely? > > Get some hardware and test that things still work, preferably > against multiple access-points. > > > - convert any remaining unusual variable types > > > > Ok (but feel free to suggest anything) > > > > - find codes that can use %pM and %Nph formatting > > > > Ok (but feel free to suggest anything) > > > > - checkpatch.pl fixes - most of the remaining ones are lines too long. Many > > of them will require refactoring > > > > Ok > > > > - merge Realtek's bugfixes and new features into the driver > > > > Please, can you explain what one could do that? > > I know that "youling 257 " is using a different > version of the original (out-of-tree, non cleaned-up) Realtek driver > code for the Android-X86 kernels he works on. You should probably > ask youling why that version is being used and try to get a copy of > the original Realtek sources on which the staging driver is based > and do a "diff -ur" between them and see what is different. > > > - switch to use LIB80211 > > - switch to use MAC80211 > > > > I think I need a few details for these last points as well. > > I'm afraid I cannot help there, you should ask for help with this > on the linux wireless email list. > > > Do you think that one will need real hardware to complete > > these tasks? I don't have rtl8723bs card at the moment, so > > I think I will focus on those TODO activities which > > don't need it. > > Yes you really do need hardware, even simple coding style > cleanups are known to (accidentally) break driver functionality, > so you really should ensure that you are capable of testing your > changes on real hardware. > > Regards, > > Hans > > thank you for your answer Hans, fabio