From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C846C43611 for ; Mon, 17 May 2021 16:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 217A661019 for ; Mon, 17 May 2021 16:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242882AbhEQQPs (ORCPT ); Mon, 17 May 2021 12:15:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:44904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240287AbhEQPvr (ORCPT ); Mon, 17 May 2021 11:51:47 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DCA2060FF3; Mon, 17 May 2021 15:24:35 +0000 (UTC) Date: Mon, 17 May 2021 11:24:34 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: LKML , Ingo Molnar , Devin Moore Subject: Re: [PATCH 1/4] bootconfig: Change array value to use child node Message-ID: <20210517112434.570fd87b@gandalf.local.home> In-Reply-To: <162117693103.9011.18172892676114426345.stgit@devnote2> References: <162117692155.9011.16682190750100804269.stgit@devnote2> <162117693103.9011.18172892676114426345.stgit@devnote2> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 16 May 2021 23:55:31 +0900 Masami Hiramatsu wrote: > Change array value to use child node of the xbc_node tree > instead of next node. Hi Masami, This says what you did, not why you did it. Can you add a comment about what the purpose of this change was? Thanks! -- Steve > > Signed-off-by: Masami Hiramatsu > --- > tools/bootconfig/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >