From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D015C433B4 for ; Mon, 17 May 2021 11:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F31961073 for ; Mon, 17 May 2021 11:37:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236899AbhEQLiy (ORCPT ); Mon, 17 May 2021 07:38:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236867AbhEQLip (ORCPT ); Mon, 17 May 2021 07:38:45 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09356C061573 for ; Mon, 17 May 2021 04:37:28 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id n2so8683692ejy.7 for ; Mon, 17 May 2021 04:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=deviqon.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I1/X7zWw77Cn/B8mk8pmFHz8eIrf1bNYDSVYUancEAA=; b=SZoE4G+b0SYwuFHNm0p71rlvZdr+1NQVZ0kDtn2ZAVWlxijQPJZUsDfCI6wqKksYW5 jwHk6Q9iSBZpJ4uSVlK3hkszpwKDuoqtwBkpAZQXjHuqJvICJO6IhM4pePqDuY999/Ax Ade4QfUSz2WRbqAJFbiM1nQT6COOyCg1YAZvQhkGyOHEj5du79nLN0uZq6c6MMg0MiRn 1Zw2NSVfIvXDHYRiNSqfR8gG2i06KNVMsMmvpbQppJEc3LD3PsG2T58IbO36BwvYbfqz zZ1XMJ/kFdPiBgeiJxPHyj5cA5UUu6c5vVWlpUb6WarSGlY3wGU/BdT+zHkNbTJivjt4 opRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=I1/X7zWw77Cn/B8mk8pmFHz8eIrf1bNYDSVYUancEAA=; b=p63/JYQhoQhlw0C6R8IEmRY4Qqnxap2zWPzunWNVK2Oas7aXVAKjLI4t5CB9ScQSxr TRuKcTCKTIOGQsSsgEmFcz9xeRufcHSgwukq4cByXGmcXF7MYsjWSKEc3EaTUK9fpXCs MLudZYbPK+GnWHeBko4MSaPInO2iyxnSsv4L3gcN7O2SyGWekaiDkYHK4FUXQFEbrP5M S1/aUO97JIfII0OXQWMMGpK94kCWVZYSahw9jpIDVlrR9ySY7fdnAepb2sg4zeOj+keC 5/lyU03/L/ZrnfJQDrtMZ2VXLpT+eVz54sD5lX9Sy8UDLqSMCwcS7hEBaoloAWjbqgcZ QB+w== X-Gm-Message-State: AOAM530dH4M9ucihjssM9XZfqHqZIeoXE/Uk0MdtJ82/rYylkxPlISBb h1wBxmIBoCTEWHMarH/Tc1dSig== X-Google-Smtp-Source: ABdhPJylNfXxsATSBE+CGwXJQZFeZM8/Ee0be9GTlYhOpFvXXtwMliz8S/BkuzgVY9LP5b+flVaoWg== X-Received: by 2002:a17:906:fcb4:: with SMTP id qw20mr11550196ejb.216.1621251446365; Mon, 17 May 2021 04:37:26 -0700 (PDT) Received: from neptune.. ([5.2.193.191]) by smtp.gmail.com with ESMTPSA id r17sm10698641edt.33.2021.05.17.04.37.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 May 2021 04:37:26 -0700 (PDT) From: Alexandru Ardelean To: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com, albeu@free.fr, Alexandru Ardelean Subject: [PATCH] gpio: gpio-ath79: remove platform_set_drvdata() + cleanup probe Date: Mon, 17 May 2021 14:37:07 +0300 Message-Id: <20210517113707.238011-1-aardelean@deviqon.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The platform_set_drvdata() call is only useful if we need to retrieve back the private information. Since the driver doesn't do that, it's not useful to have it. If this is removed, we can also just do a direct return on devm_gpiochip_add_data(). We don't need to print that this call failed as there are other ways to log/see this during probe. Signed-off-by: Alexandru Ardelean --- drivers/gpio/gpio-ath79.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c index 678ddd375891..9b780dc5d390 100644 --- a/drivers/gpio/gpio-ath79.c +++ b/drivers/gpio/gpio-ath79.c @@ -234,7 +234,6 @@ static int ath79_gpio_probe(struct platform_device *pdev) ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL); if (!ctrl) return -ENOMEM; - platform_set_drvdata(pdev, ctrl); if (np) { err = of_property_read_u32(np, "ngpios", &ath79_gpio_count); @@ -290,13 +289,7 @@ static int ath79_gpio_probe(struct platform_device *pdev) girq->handler = handle_simple_irq; } - err = devm_gpiochip_add_data(dev, &ctrl->gc, ctrl); - if (err) { - dev_err(dev, - "cannot add AR71xx GPIO chip, error=%d", err); - return err; - } - return 0; + return devm_gpiochip_add_data(dev, &ctrl->gc, ctrl); } static struct platform_driver ath79_gpio_driver = { -- 2.31.1