From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22932C433ED for ; Wed, 19 May 2021 06:39:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC4CD60FE4 for ; Wed, 19 May 2021 06:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbhESGkW (ORCPT ); Wed, 19 May 2021 02:40:22 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:38753 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230003AbhESGkV (ORCPT ); Wed, 19 May 2021 02:40:21 -0400 Received: from grover.RMN.KIBA.LAB.jp (133-32-232-101.west.xps.vectant.ne.jp [133.32.232.101]) (authenticated) by conuserg-09.nifty.com with ESMTP id 14J6bCP4005735; Wed, 19 May 2021 15:37:13 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 14J6bCP4005735 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1621406233; bh=EjAQYV3rgfCUMvcmuINMAjm4oykdL+50ig+UQDmBe8k=; h=From:To:Cc:Subject:Date:From; b=qBKdZe/587Ni26JK58OudykSEZSpUPX0bEnvmOcD7kASYy4cequeofI3hO/5zjze9 hPTxz5tVH1N8cX8oFPsWyDFsXxFX59oipOLy5B2I29Cf46d3zBVlAMbgymA+trVGPE aknA1EE+Z8gRI0CqvM1YadtD7Uwrb/NdAKwKWp4ianNhlTUwSuMCCsjYfbWLmkhrLg 8t4AptsS4+QjwYzdMhMnSFsSgwW6tJiz5i3sjizpeWP3UHnJl43XcrDcg58uOHS6IH ZFtLMJuuDiVPPBRKQSpibpRnDgbaVjvzVtgtDBCcwXsUrk15FoeiJc5eGWWgzhvVIh ma8NRcmYwu/gg== X-Nifty-SrcIP: [133.32.232.101] From: Masahiro Yamada To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira Cc: Masahiro Yamada , linux-kernel@vger.kernel.org Subject: [PATCH] sched: fix a stale comment in pick_next_task() Date: Wed, 19 May 2021 15:37:09 +0900 Message-Id: <20210519063709.323162-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fair_sched_class->next no longer exists since commit a87e749e8fa1 ("sched: Remove struct sched_class::next field"). Now the sched_class order is specified by the linker script. Rewrite the comment in a more generic way. Signed-off-by: Masahiro Yamada --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 5226cc26a095..fd3b7079b9f2 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -4961,7 +4961,7 @@ pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf) if (unlikely(p == RETRY_TASK)) goto restart; - /* Assumes fair_sched_class->next == idle_sched_class */ + /* Assume the next prioritized class is idle_sched_class */ if (!p) { put_prev_task(rq, prev); p = pick_next_task_idle(rq); -- 2.27.0