mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juerg Haefliger <juerg.haefliger@canonical.com>
To: Christoph Hellwig <hch@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Juerg Haefliger <juergh@canonical.com>
Subject: [PATCH v2 1/3] init/Kconfig: Move BLK_CGROUP to block/Kconfig
Date: Wed, 19 May 2021 10:56:13 +0200	[thread overview]
Message-ID: <20210519085615.12101-2-juergh@canonical.com> (raw)
In-Reply-To: <20210519085615.12101-1-juergh@canonical.com>

While at it, make the option prompt more descriptive and fix the help
text indentation to be 1 tab + 2 spaces.

Signed-off-by: Juerg Haefliger <juergh@canonical.com>
---
 block/Kconfig | 23 +++++++++++++++++++++++
 init/Kconfig  | 22 ----------------------
 2 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/block/Kconfig b/block/Kconfig
index a2297edfdde8..fbc4cf1a2075 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -202,6 +202,29 @@ config BLK_INLINE_ENCRYPTION_FALLBACK
 	  by falling back to the kernel crypto API when inline
 	  encryption hardware is not present.
 
+config BLK_CGROUP
+	bool "Enable block IO cgroup controller"
+	depends on CGROUPS
+	default n
+	help
+	  Generic block IO controller cgroup interface. This is the common
+	  cgroup interface which should be used by various IO controlling
+	  policies.
+
+	  Currently, CFQ IO scheduler uses it to recognize task groups and
+	  control disk bandwidth allocation (proportional time slice allocation)
+	  to such task groups. It is also used by bio throttling logic in
+	  block layer to implement upper limit in IO rates on a device.
+
+	  This option only enables generic Block IO controller infrastructure.
+	  One needs to also enable actual IO controlling logic/policy. For
+	  enabling proportional weight division of disk bandwidth in CFQ, set
+	  CONFIG_BFQ_GROUP_IOSCHED=y; for enabling throttling policy, set
+	  CONFIG_BLK_DEV_THROTTLING=y.
+
+	  See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more
+	  information.
+
 menu "Partition Types"
 
 source "block/partitions/Kconfig"
diff --git a/init/Kconfig b/init/Kconfig
index 1ea12c64e4c9..5be10c091603 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -921,28 +921,6 @@ config MEMCG_KMEM
 	depends on MEMCG && !SLOB
 	default y
 
-config BLK_CGROUP
-	bool "IO controller"
-	depends on BLOCK
-	default n
-	help
-	Generic block IO controller cgroup interface. This is the common
-	cgroup interface which should be used by various IO controlling
-	policies.
-
-	Currently, CFQ IO scheduler uses it to recognize task groups and
-	control disk bandwidth allocation (proportional time slice allocation)
-	to such task groups. It is also used by bio throttling logic in
-	block layer to implement upper limit in IO rates on a device.
-
-	This option only enables generic Block IO controller infrastructure.
-	One needs to also enable actual IO controlling logic/policy. For
-	enabling proportional weight division of disk bandwidth in CFQ, set
-	CONFIG_BFQ_GROUP_IOSCHED=y; for enabling throttling policy, set
-	CONFIG_BLK_DEV_THROTTLING=y.
-
-	See Documentation/admin-guide/cgroup-v1/blkio-controller.rst for more information.
-
 config CGROUP_WRITEBACK
 	bool
 	depends on MEMCG && BLK_CGROUP
-- 
2.27.0


  reply	other threads:[~2021-05-19  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19  8:56 [PATCH v2 0/3] block: Cleanup Kconfigs Juerg Haefliger
2021-05-19  8:56 ` Juerg Haefliger [this message]
2021-05-19  9:01   ` [PATCH v2 1/3] init/Kconfig: Move BLK_CGROUP to block/Kconfig Christoph Hellwig
2021-05-19  8:56 ` [PATCH v2 2/3] block/Kconfig: Whitespace and indentation cleanups Juerg Haefliger
2021-05-19  9:02   ` Christoph Hellwig
2021-05-19  8:56 ` [PATCH v2 3/3] block/Kconfig.iosched: " Juerg Haefliger
2021-05-19  9:09   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519085615.12101-2-juergh@canonical.com \
    --to=juerg.haefliger@canonical.com \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=juergh@canonical.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®