mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Halaney <ahalaney@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] init/main.c: silence some -Wunused-parameter warnings
Date: Wed, 19 May 2021 21:37:31 -0700	[thread overview]
Message-ID: <20210519213731.fd8699098bf79bfd23c73090@linux-foundation.org> (raw)
In-Reply-To: <20210519162341.1275452-1-ahalaney@redhat.com>

On Wed, 19 May 2021 11:23:41 -0500 Andrew Halaney <ahalaney@redhat.com> wrote:

> There's a bunch of callbacks with unused arguments, go ahead and silence
> those so "make KCFLAGS=-W init/main.o" is a little quieter.
> Here's a little sample:

Do we care about -Wunused-parameter?  I suppose we do, as it might
point us at small code optimizations.

How voluminous is the warning output from -Wunused-parameter?  Small
enough to be useful or large enough to be useless?


  reply	other threads:[~2021-05-20  4:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-19 16:23 Andrew Halaney
2021-05-20  4:37 ` Andrew Morton [this message]
2021-05-20 13:03   ` Andrew Halaney
2021-05-21  7:34     ` Rasmus Villemoes
2021-10-18 13:58       ` Andrew Halaney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210519213731.fd8699098bf79bfd23c73090@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=ahalaney@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®