From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AABC0C433B4 for ; Thu, 20 May 2021 04:55:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89937611BD for ; Thu, 20 May 2021 04:55:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230297AbhETE4v (ORCPT ); Thu, 20 May 2021 00:56:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:60876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229498AbhETE4u (ORCPT ); Thu, 20 May 2021 00:56:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AE678611AE; Thu, 20 May 2021 04:55:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621486529; bh=UjIwKnKZAr/joCW4sZFOAQoYzu0+7GxEtfQxicLk82U=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=SSa9GdgxCPYoZcxuAQ0q+v67MrLj4tL22aFghoFfWTWUQXcZ20vx+gv1HxFLKfhpq 3eQpmjk/acIgO1MrfAHFJ0BNkdFbYEwWC6HMnFUuht/CO+DXdoK0UYlXUGUtp+l1JX 1rRDxnU2s5mdam1L7h9dhbSGIMsFD6H7dnKx+GmjWB4Nco8R1XibDtNUclkdTVBy1F R0vn8/SUcmqG/CXR94Eu9z0HeqdCgIm2jn3vPenW4ydAaHU7171nfGtG0cpXt6QCqn vMu5lonTK6xaSwETmb0N70XAINGwjfF/ACOBKppThbJ3Fw0mCmwnNfX7oSGo/+0eQT 4Ynj+tvPeZ+nQ== Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 6E21E5C0138; Wed, 19 May 2021 21:55:29 -0700 (PDT) Date: Wed, 19 May 2021 21:55:29 -0700 From: "Paul E. McKenney" To: Feng Tang Cc: kernel test robot , 0day robot , Thomas Gleixner , John Stultz , Stephen Boyd , Jonathan Corbet , Mark Rutland , Marc Zyngier , Andi Kleen , Xing Zhengjun , LKML , lkp@lists.01.org, ying.huang@intel.com, zhengjun.xing@intel.com, kernel-team@fb.com, neeraju@codeaurora.org, rui.zhang@intel.com Subject: Re: [clocksource] 388450c708: netperf.Throughput_tps -65.1% regression Message-ID: <20210520045529.GH4441@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20210501003247.2448287-4-paulmck@kernel.org> <20210513155515.GB23902@xsang-OptiPlex-9020> <20210513170707.GA975577@paulmck-ThinkPad-P17-Gen-1> <20210514074314.GB5384@shbuild999.sh.intel.com> <20210514174908.GI975577@paulmck-ThinkPad-P17-Gen-1> <20210516063419.GA22111@shbuild999.sh.intel.com> <20210519060902.GE78241@shbuild999.sh.intel.com> <20210519180521.GZ4441@paulmck-ThinkPad-P17-Gen-1> <20210520005210.GA18083@shbuild999.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520005210.GA18083@shbuild999.sh.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 08:52:10AM +0800, Feng Tang wrote: > On Wed, May 19, 2021 at 11:05:21AM -0700, Paul E. McKenney wrote: > > On Wed, May 19, 2021 at 02:09:02PM +0800, Feng Tang wrote: > > > On Sun, May 16, 2021 at 02:34:19PM +0800, Feng Tang wrote: > > > > On Fri, May 14, 2021 at 10:49:08AM -0700, Paul E. McKenney wrote: > > > > > On Fri, May 14, 2021 at 03:43:14PM +0800, Feng Tang wrote: > > > > > > Hi Paul, > > > > > > > > > > > > On Thu, May 13, 2021 at 10:07:07AM -0700, Paul E. McKenney wrote: > > > > > > > On Thu, May 13, 2021 at 11:55:15PM +0800, kernel test robot wrote: > > > > > > > > > > > > > > > > > > > > > > > > Greeting, > > > > > > > > > > > > > > > > FYI, we noticed a -65.1% regression of netperf.Throughput_tps due to commit: > > > > > > > > > > > > > > > > > > > > > > > > commit: 388450c7081ded73432e2b7148c1bb9a0b039963 ("[PATCH v12 clocksource 4/5] clocksource: Reduce clocksource-skew threshold for TSC") > > > > > > > > url: https://github.com/0day-ci/linux/commits/Paul-E-McKenney/Do-not-mark-clocks-unstable-due-to-delays-for-v5-13/20210501-083404 > > > > > > > > base: https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git 2d036dfa5f10df9782f5278fc591d79d283c1fad > > > > > > > > > > > > > > > > in testcase: netperf > > > > > > > > on test machine: 96 threads 2 sockets Ice Lake with 256G memory > > > > > > > > with following parameters: > > > > > > > > > > > > > > > > ip: ipv4 > > > > > > > > runtime: 300s > > > > > > > > nr_threads: 25% > > > > > > > > cluster: cs-localhost > > > > > > > > test: UDP_RR > > > > > > > > cpufreq_governor: performance > > > > > > > > ucode: 0xb000280 > > > > > > > > > > > > > > > > test-description: Netperf is a benchmark that can be use to measure various aspect of networking performance. > > > > > > > > test-url: http://www.netperf.org/netperf/ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > If you fix the issue, kindly add following tag > > > > > > > > Reported-by: kernel test robot > > > > > > > > > > > > > > > > > > > > > > > > also as Feng Tang checked, this is a "unstable clocksource" case. > > > > > > > > attached dmesg FYI. > > > > > > > > > > > > > > Agreed, given the clock-skew event and the resulting switch to HPET, > > > > > > > performance regressions are expected behavior. > > > > > > > > > > > > > > That dmesg output does demonstrate the value of Feng Tang's patch! > > > > > > > > > > > > > > I don't see how to obtain the values of ->mult and ->shift that would > > > > > > > allow me to compute the delta. So if you don't tell me otherwise, I > > > > > > > will assume that the skew itself was expected on this hardware, perhaps > > > > > > > somehow due to the tpm_tis_status warning immediately preceding the > > > > > > > clock-skew event. If my assumption is incorrect, please let me know. > > > > > > > > > > > > I run the case with the debug patch applied, the info is: > > > > > > > > > > > > [ 13.796429] clocksource: timekeeping watchdog on CPU19: Marking clocksource 'tsc' as unstable because the skew is too large: > > > > > > [ 13.797413] clocksource: 'hpet' wd_nesc: 505192062 wd_now: 10657158 wd_last: fac6f97 mask: ffffffff > > > > > > [ 13.797413] clocksource: 'tsc' cs_nsec: 504008008 cs_now: 3445570292aa5 cs_last: 344551f0cad6f mask: ffffffffffffffff > > > > > > [ 13.797413] clocksource: 'tsc' is current clocksource. > > > > > > [ 13.797413] tsc: Marking TSC unstable due to clocksource watchdog > > > > > > [ 13.844513] clocksource: Checking clocksource tsc synchronization from CPU 50 to CPUs 0-1,12,22,32-33,60,65. > > > > > > [ 13.855080] clocksource: Switched to clocksource hpet > > > > > > > > > > > > So the delta is 1184 us (505192062 - 504008008), and I agree with > > > > > > you that it should be related with the tpm_tis_status warning stuff. > > > > > > > > > > > > But this re-trigger my old concerns, that if the margins calculated > > > > > > for tsc, hpet are too small? > > > > > > > > > > If the error really did disturb either tsc or hpet, then we really > > > > > do not have a false positive, and nothing should change (aside from > > > > > perhaps documenting that TPM issues can disturb the clocks, or better > > > > > yet treating that perturbation as a separate bug that should be fixed). > > > > > But if this is yet another way to get a confused measurement, then it > > > > > would be better to work out a way to reject the confusion and keep the > > > > > tighter margins. I cannot think right off of a way that this could > > > > > cause measurement confusion, but you never know. > > > > > > > > I have no doubt in the correctness of the measuring method, but was > > > > just afraid some platforms which use to 'just work' will be caught :) > > > > > > > > > So any thoughts on exactly how the tpm_tis_status warning might have > > > > > resulted in the skew? > > > > > > > > The tpm error message has been reported before, and from google there > > > > were some similar errors, we'll do some further check. > > > > > > Some update on this: further debug shows it is not related to TPM > > > module, as the 'unstable' still happens even if we disable TPM > > > module in kernel. > > > > > > We run this case on another test box of same type but with latest > > > BIOS and microcode, the tsc freq is correctly calculated and the > > > 'unstable' error can't be reproduced. And we will check how to > > > upgrade the test box in 0day. > > > > So this patch series might have located a real BIOS or firmware bug, > > then? ;-) > > Yes, it did a good job in exposing a real-world bug! (lucky > thing is the bug has a fix :)) Even better! ;-) Thanx, Paul