From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8904C433ED for ; Fri, 21 May 2021 11:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9E5D613CE for ; Fri, 21 May 2021 11:25:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234660AbhEUL0e (ORCPT ); Fri, 21 May 2021 07:26:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231364AbhEUL0b (ORCPT ); Fri, 21 May 2021 07:26:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 550A060E09; Fri, 21 May 2021 11:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621596309; bh=0QLS03Am82gWxNzfPbPumFkWehre23Y1zPmBLcVt0+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=o8TJV3MSrd+BUggm1UVjjXHIjKMdoqxvI/zoI7coPCrWcW8xBMJ2RdP6fuw03Xcnz Ye3GaH9jyxom61gbcKUF4NCqbGCoGsWMrlspqLOOVH3G0WHakHB+vM1V7KgqkyFZaT pK8HPLRGbxgGLqnz/WZT3nC1KoL+de8/268i1OUYw+9PgpQUwMhvI2R/AfxMqxJTlS 0qaTDyYBYnf+bZgW8M2RFznh28yWjXh+qfq81xN9Zx7QKjlRBFYCGqm49JXHObk3qF l0CyQmk/Bx4lMrBd1RHVnOoLb43IfNohnwK5GHZCmsTP78G4g7DeqB/cG3bbcED22X DGsGq9/WuwESQ== Date: Fri, 21 May 2021 12:25:04 +0100 From: Will Deacon To: Mika =?iso-8859-1?Q?Penttil=E4?= Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Frederic Weisbecker , Thomas Gleixner , Marc Zyngier , Lorenzo Colitti , John Stultz , Stephen Boyd , kernel-team@android.com Subject: Re: [PATCH 3/5] tick/broadcast: Prefer per-cpu oneshot wakeup timers to broadcast Message-ID: <20210521112503.GA11850@willie-the-truck> References: <20210520184705.10845-1-will@kernel.org> <20210520184705.10845-4-will@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 21, 2021 at 05:25:41AM +0300, Mika Penttilä wrote: > On 20.5.2021 21.47, Will Deacon wrote: > > /* > > * Conditionally install/replace broadcast device > > */ > > -void tick_install_broadcast_device(struct clock_event_device *dev) > > +void tick_install_broadcast_device(struct clock_event_device *dev, int cpu) > > { > > struct clock_event_device *cur = tick_broadcast_device.evtdev; > > + if (tick_set_oneshot_wakeup_device(dev, cpu)) > > + return; > > + > > if (!tick_check_broadcast_device(cur, dev)) > > return; > > Does this disable hpet registering as a global broadcast device on x86 ? I > think it starts with cpumask = cpu0 so it qualifies for a percpu wakeup > timer. Well spotted, I think you're probably right. I'll try to reproduce on my laptop to confirm, but I hadn't noticed the tricks played with the cpumask on x86. I'll probably need to rework things so that we install the broadcast timer first, but prefer global devices. Will