From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C1E0C04FF3 for ; Mon, 24 May 2021 09:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C8FD60698 for ; Mon, 24 May 2021 09:01:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232446AbhEXJCx (ORCPT ); Mon, 24 May 2021 05:02:53 -0400 Received: from mx2.suse.de ([195.135.220.15]:45058 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232387AbhEXJCw (ORCPT ); Mon, 24 May 2021 05:02:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1621846884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KyNpmtPVi73FGeb1l6Zw5sAifVTsA3JabmYau6KyfuA=; b=zYsYVoH9VhNWsgDUh6b0ZYXw8eSMiYym0dV2eQNI2KQ84vV9jxPPQl49oiqCU1SnZ3WX8o ZcvAhdkn8jL3KlUQpWNkWQ/vQeJk6crxekCclW49tydOB7YFezPMI5Y8joOOj7E46jKAkL ownrc28Lyzuo1o0sjz7CzY/9ZsKj53o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1621846884; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KyNpmtPVi73FGeb1l6Zw5sAifVTsA3JabmYau6KyfuA=; b=D89WDl5h/v+pyiNg2DvJVSqEzUzc4N+HStDLgLaKamYvZBqb9L4XDtVqpBqqFzlp67Xj9X wmyudGcgk2hOJNAA== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id EFAABAC11; Mon, 24 May 2021 09:01:23 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 8D5B91F2CA2; Mon, 24 May 2021 11:01:23 +0200 (CEST) Date: Mon, 24 May 2021 11:01:23 +0200 From: Jan Kara To: YueHaibing Cc: jack@suse.cz, reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page() Message-ID: <20210524090123.GE32705@quack2.suse.cz> References: <20210523090258.27696-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210523090258.27696-1-yuehaibing@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 23-05-21 17:02:58, YueHaibing wrote: > Condition !A || A && B is equivalent to !A || B. > > Generated by: scripts/coccinelle/misc/excluded_middle.cocci > > Signed-off-by: YueHaibing Fair enough. Thanks for the patch. Added to my tree. Honza > --- > fs/reiserfs/inode.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c > index 780bb90c1804..f49b72ccac4c 100644 > --- a/fs/reiserfs/inode.c > +++ b/fs/reiserfs/inode.c > @@ -2584,9 +2584,7 @@ static int reiserfs_write_full_page(struct page *page, > clear_buffer_dirty(bh); > set_buffer_uptodate(bh); > } else if ((checked || buffer_dirty(bh)) && > - (!buffer_mapped(bh) || (buffer_mapped(bh) > - && bh->b_blocknr == > - 0))) { > + (!buffer_mapped(bh) || bh->b_blocknr == 0)) { > /* > * not mapped yet, or it points to a direct item, search > * the btree for the mapping info, and log any direct > -- > 2.20.1 > -- Jan Kara SUSE Labs, CR