mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>
To: gregkh@linuxfoundation.org, ross.schm.dev@gmail.com,
	straube.linux@gmail.com, fabioaiuto83@gmail.com
Cc: Shreyansh Chouhan <chouhan.shreyansh630@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] staging: rtl8723bs: fix indents in rtw_wlan_util.c
Date: Mon, 24 May 2021 19:21:02 +0530	[thread overview]
Message-ID: <20210524135105.5550-1-chouhan.shreyansh630@gmail.com> (raw)

This patch series aims to solve all indent related issues for the file
core/rtw_wlan_util.c.

The first two patches fix the follwing issues reported by checkpatch.pl:

WARNING: Too many leading tabs - consider code refactoring
#887: FILE: rtw_wlan_util.c:887:
+                                               if ((edca[j] >> 16) > (edca[i] >> 16))

WARNING: Too many leading tabs - consider code refactoring
#1528: FILE: rtw_wlan_util.c:1528:
+                                               if (pIE->data[5] & RT_HT_CAP_USE_92SE)

WARNING: Too many leading tabs - consider code refactoring
#1536: FILE: rtw_wlan_util.c:1536:
+                                               if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_BCUT)

WARNING: Too many leading tabs - consider code refactoring
#1539: FILE: rtw_wlan_util.c:1539:
+                                               if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_CCUT)


The last patch fixes the follwing issues reported by checkpatch.pl:

WARNING: suspect code indent for conditional statements (8, 24)
#1257: FILE: rtw_wlan_util.c:1257:
+       if (p && len > 0) {
+                       pht_cap = (struct ieee80211_ht_cap *)(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1260: FILE: rtw_wlan_util.c:1260:
+       } else {
+                       ht_cap_info = 0;

WARNING: suspect code indent for conditional statements (8, 24)
#1265: FILE: rtw_wlan_util.c:1265:
+       if (p && len > 0) {
+                       pht_info = (struct HT_info_element *)(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1268: FILE: rtw_wlan_util.c:1268:
+       } else {
+                       ht_info_infos_0 = 0;

WARNING: suspect code indent for conditional statements (8, 24)
#1271: FILE: rtw_wlan_util.c:1271:
+       if (ht_cap_info != cur_network->BcnInfo.ht_cap_info ||
[...]
+                       {

WARNING: suspect code indent for conditional statements (8, 24)
#1284: FILE: rtw_wlan_util.c:1284:
+       if (p) {
+                       bcn_channel = *(p + 2);

WARNING: suspect code indent for conditional statements (8, 24)
#1295: FILE: rtw_wlan_util.c:1295:
+       if (bcn_channel != Adapter->mlmeextpriv.cur_channel)
+                       goto _mismatch;

Shreyansh Chouhan (3):
  staging: rtl8723bs: refactor to reduce indents
  staging: rtl8723bs: remove unnecessary braces from conditionals
  staging: rtl8723bs: fix suspect indents

 .../staging/rtl8723bs/core/rtw_wlan_util.c    | 161 +++++++++---------
 1 file changed, 82 insertions(+), 79 deletions(-)

-- 
2.31.1


             reply	other threads:[~2021-05-24 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-24 13:51 Shreyansh Chouhan [this message]
2021-05-24 13:51 ` [PATCH 1/3] staging: rtl8723bs: refactor to reduce indents Shreyansh Chouhan
2021-05-24 13:51 ` [PATCH 2/3] staging: rtl8723bs: remove unnecessary braces from conditionals Shreyansh Chouhan
2021-05-24 13:51 ` [PATCH 3/3] staging: rtl8723bs: fix suspect indents Shreyansh Chouhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210524135105.5550-1-chouhan.shreyansh630@gmail.com \
    --to=chouhan.shreyansh630@gmail.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=ross.schm.dev@gmail.com \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®