From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EAA6C47093 for ; Mon, 24 May 2021 15:10:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01F4360698 for ; Mon, 24 May 2021 15:10:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235528AbhEXPLB (ORCPT ); Mon, 24 May 2021 11:11:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:37714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233398AbhEXPCj (ORCPT ); Mon, 24 May 2021 11:02:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 425136146D; Mon, 24 May 2021 14:50:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621867825; bh=NVhnBFxxbsod3bZ71tcKvqdmuRUUR+JQxC8nBsemxoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y4Xs0b2VcCNabz7EKWSandA0BhWIK5mbNLiew0xWJWq+Lhb7ogFqUacvUAAZR9KjL Pa+azSuiNAjG65B1irOtLplIDL1x5tOQAYmvzBBHMO4QdUfRqck2qWLILNtsbtZQlG j8w1IPFwMG0UY4QZYvNw6e7gmmEXZYTY5AVpeHGEmRQ9qcLHAY7m0OvSXRvXjZSeyh mYq4LpQojJO+Vkq/IC3+4xh3lNxuAXs1YG3Gp1o+vT6+M2Z6lkKhcrlYeOd1TlQT+n 9eubhl4j5QHzttciiUaSDOuwg9ORawfGDPxqdEYkyUk546obYaK6sP/aMC0pT102Zc JNe3UYIK2Ef1Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Alaa Emad , Sean Young , Mauro Carvalho Chehab , Greg Kroah-Hartman , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 13/25] media: dvb: Add check on sp8870_readreg return Date: Mon, 24 May 2021 10:49:56 -0400 Message-Id: <20210524145008.2499049-13-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210524145008.2499049-1-sashal@kernel.org> References: <20210524145008.2499049-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alaa Emad [ Upstream commit c6d822c56e7fd29e6fa1b1bb91b98f6a1e942b3c ] The function sp8870_readreg returns a negative value when i2c_transfer fails so properly check for this and return the error if it happens. Cc: Sean Young Cc: Mauro Carvalho Chehab Signed-off-by: Alaa Emad Link: https://lore.kernel.org/r/20210503115736.2104747-60-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/media/dvb-frontends/sp8870.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/sp8870.c b/drivers/media/dvb-frontends/sp8870.c index 8d31cf3f4f07..3a577788041d 100644 --- a/drivers/media/dvb-frontends/sp8870.c +++ b/drivers/media/dvb-frontends/sp8870.c @@ -293,7 +293,9 @@ static int sp8870_set_frontend_parameters(struct dvb_frontend *fe) sp8870_writereg(state, 0xc05, reg0xc05); // read status reg in order to clear pending irqs - sp8870_readreg(state, 0x200); + err = sp8870_readreg(state, 0x200); + if (err < 0) + return err; // system controller start sp8870_microcontroller_start(state); -- 2.30.2