From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Aniket Bhattacharyea <aniketmail669@gmail.com>
Cc: mchehab@kernel.org, gregkh@linuxfoundation.org,
andriy.shevchenko@linux.intel.com, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: atomisp: Replace whitespace at the beginning of line
Date: Mon, 24 May 2021 18:20:06 +0300 [thread overview]
Message-ID: <20210524152006.GP3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210520155013.929465-1-aniketmail669@gmail.com>
Hi Aniket,
On Thu, May 20, 2021 at 09:20:13PM +0530, Aniket Bhattacharyea wrote:
> This patch replaces the whitespaces at the beginning of line with tabs.
> Identified by checkpatch: WARNING: please, no spaces at the start of a line.
>
> Signed-off-by: Aniket Bhattacharyea <aniketmail669@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index 135994d44802..93ac7e183344 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
> };
>
> struct camera_sensor_platform_data *gmin_camera_platform_data(
> - struct v4l2_subdev *subdev,
> - enum atomisp_input_format csi_format,
> - enum atomisp_bayer_order csi_bayer)
> + struct v4l2_subdev *subdev,
> + enum atomisp_input_format csi_format,
> + enum atomisp_bayer_order csi_bayer)
Please wrap instead after the type if the type and name are too long.
I.e.
struct camera_sensor_platform_data *
gmin_camera_platform_data(...,
...);
> {
> u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
> struct gmin_subdev *gs;
--
Regards,
Sakari Ailus
prev parent reply other threads:[~2021-05-24 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 15:50 Aniket Bhattacharyea
2021-05-24 15:20 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524152006.GP3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aniketmail669@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®