From: Maxime Ripard <maxime@cerno.tech>
To: Andreas Rehn <rehn.andreas86@gmail.com>
Cc: wens@csie.org, jernej.skrabec@gmail.com,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: sun8i: v3s: enable emac for zero Dock
Date: Tue, 25 May 2021 10:06:21 +0200 [thread overview]
Message-ID: <20210525080621.m7qpnfdarkrg3vn5@gilmour> (raw)
In-Reply-To: <20210522222329.192367-1-rehn.andreas86@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]
Hi Andreas,
On Sun, May 23, 2021 at 12:23:29AM +0200, Andreas Rehn wrote:
> dwmac-sun8i supports v3s and
> Licheepi-zero Dock provides an ethernet port
>
> Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
> ---
> Changes in v2:
> - add ethernet0 alias.
>
> arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> index db5cd0b8574b..4d564028f286 100644
> --- a/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> +++ b/arch/arm/boot/dts/sun8i-v3s-licheepi-zero-dock.dts
> @@ -49,6 +49,10 @@ / {
> compatible = "licheepi,licheepi-zero-dock", "licheepi,licheepi-zero",
> "allwinner,sun8i-v3s";
>
> + aliases {
> + ethernet0 = &emac;
> + };
> +
> leds {
> /* The LEDs use PG0~2 pins, which conflict with MMC1 */
> status = "disabled";
> @@ -94,3 +98,8 @@ button-800 {
> voltage = <800000>;
> };
> };
> +
> +&emac {
> + allwinner,leds-active-low;
> + status = "okay";
> +};
We use alphabetical order for phandle derefences
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2021-05-25 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 20:50 [PATCH] " Andreas Rehn
2021-05-22 21:36 ` Andre Przywara
2021-05-22 22:23 ` [PATCH v2] " Andreas Rehn
2021-05-25 8:06 ` Maxime Ripard [this message]
2021-05-25 17:31 ` [PATCH v3] " Andreas Rehn
2021-05-26 23:16 ` Andre Przywara
2021-05-31 9:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525080621.m7qpnfdarkrg3vn5@gilmour \
--to=maxime@cerno.tech \
--cc=jernej.skrabec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=rehn.andreas86@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®