From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A823C2B9F8 for ; Tue, 25 May 2021 13:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F29761409 for ; Tue, 25 May 2021 13:46:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233407AbhEYNsT (ORCPT ); Tue, 25 May 2021 09:48:19 -0400 Received: from elvis.franken.de ([193.175.24.41]:48749 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233345AbhEYNsO (ORCPT ); Tue, 25 May 2021 09:48:14 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1llXO3-00079x-03; Tue, 25 May 2021 15:46:23 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 59886C1109; Tue, 25 May 2021 15:40:39 +0200 (CEST) Date: Tue, 25 May 2021 15:40:39 +0200 From: Thomas Bogendoerfer To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, kernel test robot , linux-mips@vger.kernel.org, Ilya Lipnitskiy Subject: Re: [PATCH] MIPS: launch.h: add include guard to prevent build errors Message-ID: <20210525134039.GD11166@alpha.franken.de> References: <20210521051343.20059-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210521051343.20059-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 10:13:43PM -0700, Randy Dunlap wrote: > arch/mips/include/asm/mips-boards/launch.h needs an include guard > to prevent it from being #included more than once. > Prevents these build errors: > > In file included from ../arch/mips/mti-malta/malta-amon.c:16: > ../arch/mips/include/asm/mips-boards/launch.h:8:8: error: redefinition of 'struct cpulaunch' > 8 | struct cpulaunch { > | ^~~~~~~~~ > In file included from ../arch/mips/include/asm/mips-cps.h:13, > from ../arch/mips/include/asm/smp-ops.h:16, > from ../arch/mips/include/asm/smp.h:21, > from ../include/linux/smp.h:114, > from ../arch/mips/mti-malta/malta-amon.c:12: > ../arch/mips/include/asm/mips-boards/launch.h:8:8: note: originally defined here > 8 | struct cpulaunch { > | ^~~~~~~~~ > make[3]: [../scripts/Makefile.build:273: arch/mips/mti-malta/malta-amon.o] Error 1 (ignored) > > Fixes: 6decd1aad15f ("MIPS: add support for buggy MT7621S core detection") > Signed-off-by: Randy Dunlap > Reported-by: kernel test robot > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > Cc: Ilya Lipnitskiy > --- > arch/mips/include/asm/mips-boards/launch.h | 5 +++++ > 1 file changed, 5 insertions(+) applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]