From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBBDEC47088 for ; Tue, 25 May 2021 23:17:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA376613E6 for ; Tue, 25 May 2021 23:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231321AbhEYXS3 (ORCPT ); Tue, 25 May 2021 19:18:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:36630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230145AbhEYXS2 (ORCPT ); Tue, 25 May 2021 19:18:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F9A861042; Tue, 25 May 2021 23:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1621984616; bh=1L+wt9+EMclSFh/NImV8VXARHos+R8K+93TCAp42yGw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XAsPL0sTczCZgtSYc1suxOXPRTi+wtwTzolMB7oyFsPRG3TE2eUow3D+VjQSWwdqO jrD2xkHhN9GJhAUaoRlNsZAi9H7oRwWTM0lIvBAEQKR+TYhJNQzWCryVRYgD1UN18x ClFCYF+jOvH++Nq09N50WoXd2zK41Riuz3kK4ukc= Date: Tue, 25 May 2021 16:16:55 -0700 From: Andrew Morton To: Vlastimil Babka Cc: Yejune Deng , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, Sebastian Andrzej Siewior , Thomas Gleixner , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yejune Deng Subject: Re: [PATCH 2/2] mm: slub: use DEFINE_RAW_SPINLOCK init object_map_lock Message-Id: <20210525161655.bd9f91e9c29758142eb955e2@linux-foundation.org> In-Reply-To: <427f87d6-b506-a225-1887-cf8c13d99634@suse.cz> References: <1621938235-11947-1-git-send-email-yejunedeng@gmail.com> <1621938235-11947-2-git-send-email-yejunedeng@gmail.com> <427f87d6-b506-a225-1887-cf8c13d99634@suse.cz> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 May 2021 12:46:35 +0200 Vlastimil Babka wrote: > On 5/25/21 12:23 PM, Yejune Deng wrote: > > Use DEFINE_RAW_SPINLOCK instead of DEFINE_SPINLOCK object_map_lock > > that won't be preempted on mainline and PREEMPT_RT kernels. > > > > Signed-off-by: Yejune Deng > > RT tree also has such patch, with IMHO more thorough description: Yes please, a more thorough decription is needed. The description provided with this patch could be applied to every spinlock in the kernel!