From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_RED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D1EC2B9F7 for ; Wed, 26 May 2021 08:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8299613B0 for ; Wed, 26 May 2021 08:31:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhEZIdE (ORCPT ); Wed, 26 May 2021 04:33:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231410AbhEZIdD (ORCPT ); Wed, 26 May 2021 04:33:03 -0400 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17B36C061574 for ; Wed, 26 May 2021 01:31:31 -0700 (PDT) Received: by mail-wr1-x436.google.com with SMTP id q5so161229wrs.4 for ; Wed, 26 May 2021 01:31:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a9K2ZcaJ0UvKBWGL+DeoaKZZOV/me504do+MmjS7kGQ=; b=P70uwTkXc4vT2c5pOT9UmXAbxVfDBayRnjnwKwb5i7xU93GCfNy57HkEeIDQDX9kyr oGV3731A637cYdMYRfYKRmso14jvlvYj2Hv2+JvBWrmC2f8g+Zvu8Z07NusMsWY3GPhc UKmwoOnj1kuWVpOi1yblzuJ09IedkNgv40hsi0IbNutDC+tUeoLExdQEkLkUw/yivu5X 7AyciQWIxE6XD/2+z7F+tutFB0FiQnVj5DLOfvTB5a+Q0dk6wcOut7y1lJlSMlbDGK7/ MNd4rgdmsA8VDeVVg1zxVlukBaMXeXhNfLO/NNjaEBd0LXxpxnVg48MMhrqz55ts+ajA tNLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=a9K2ZcaJ0UvKBWGL+DeoaKZZOV/me504do+MmjS7kGQ=; b=DhCmdex0T8PWcb0PEiAdb0s1Io6IfTKdX0pRFJKOwVNOTCKFRISyufxPli6KfYwono BMOZdYBtZl+I4RANJGbvuNFF15FbrKnWtMiHk9X1LYM/OWhn4xeD+p6RkdFaAlErWM9i CE+4vUFc9gQWaC1ecL0DR8taXTH1ovQFMtX6MsxOnM++xa9fMMnrbN4GXNYzXKPKgZSJ uU5XlK71NzCWZOK7Nl2p7jYkSus8v+JaZN/hS8xvsWiW9XgJ5DYNZIVNlqMjXi/iX+3u IEAlplard3KCCdimYz7ZglNTc8QH5L4sva0JfsbafNCunU3yyMJSlntIzU/7mDMpwBv0 DB0Q== X-Gm-Message-State: AOAM532B8+lRoW9b2qvOgNY5jaT+IdxDUJBCoxlTwNf1qhIkPJufGyxF ISk9k8iQaV8ZCYeHcrkJ8ATbtw== X-Google-Smtp-Source: ABdhPJyPsFXwbE1eTXxhQ/j5Y7oVhYsoZXPs/ZRPePhKsZQ/rDuz008HdVucTiMSLr9J9LdkFn9Rgw== X-Received: by 2002:a05:6000:1b0b:: with SMTP id f11mr32015361wrz.165.1622017889499; Wed, 26 May 2021 01:31:29 -0700 (PDT) Received: from dell.default ([91.110.221.223]) by smtp.gmail.com with ESMTPSA id r4sm237828wre.84.2021.05.26.01.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 May 2021 01:31:28 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , "Andrew J. Kroll" , processes-Sapan Bhatia Subject: [PATCH v2 1/1] tty: n_tty: Fix some misdocumented functions Date: Wed, 26 May 2021 09:31:25 +0100 Message-Id: <20210526083125.549626-1-lee.jones@linaro.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/tty/n_tty.c:623: warning: expecting prototype for process_echoes(). Prototype was for __process_echoes() instead drivers/tty/n_tty.c:1109: warning: expecting prototype for isig(). Prototype was for __isig() instead drivers/tty/n_tty.c:1268: warning: expecting prototype for n_tty_receive_char(). Prototype was for n_tty_receive_char_special() instead drivers/tty/n_tty.c:2132: warning: Excess function parameter 'buf' description in 'n_tty_read' Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: "Andrew J. Kroll" Cc: processes-Sapan Bhatia Signed-off-by: Lee Jones --- v2: Rebased drivers/tty/n_tty.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 0ec93f1a61f5d..56d3b43d8a3a4 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -596,7 +596,7 @@ static ssize_t process_output_block(struct tty_struct *tty, } /** - * process_echoes - write pending echo characters + * __process_echoes - write pending echo characters * @tty: terminal device * * Write previously buffered echo (and other ldisc-generated) @@ -1092,7 +1092,7 @@ static void eraser(unsigned char c, struct tty_struct *tty) } /** - * isig - handle the ISIG optio + * __isig - handle the ISIG optio * @sig: signal * @tty: terminal * @@ -1248,7 +1248,7 @@ n_tty_receive_signal_char(struct tty_struct *tty, int signal, unsigned char c) } /** - * n_tty_receive_char - perform processing + * n_tty_receive_char_special - perform processing * @tty: terminal device * @c: character * @@ -2042,11 +2042,11 @@ static int job_control(struct tty_struct *tty, struct file *file) } -/** +/* * n_tty_read - read function for tty * @tty: tty device * @file: file object - * @buf: userspace buffer pointer + * @kbuf: userspace buffer pointer * @nr: size of I/O * * Perform reads for the line discipline. We are guaranteed that the -- 2.31.1