From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Wan Jiabing <wanjiabing@vivo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiabing Wan <kael_w@yeah.net>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] staging: media: atomisp: Align block comments
Date: Thu, 27 May 2021 00:44:32 +0300 [thread overview]
Message-ID: <20210526214431.GJ3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210518112938.88240-1-wanjiabing@vivo.com>
Hi Jiabing,
On Tue, May 18, 2021 at 07:29:35PM +0800, Wan Jiabing wrote:
> From: Jiabing Wan <kael_w@yeah.net>
>
> Fixing the following checkpatch warning:
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Jiabing Wan <kael_w@yeah.net>
> ---
> Changelog:
> v2:
> - Fix the author style in patch.
> ---
> .../atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> index be3534e46c15..9b22f2da45d5 100644
> --- a/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> +++ b/drivers/staging/media/atomisp/pci/isp/kernels/anr/anr_1.0/ia_css_anr_types.h
> @@ -17,8 +17,8 @@
> #define __IA_CSS_ANR_TYPES_H
>
> /* @file
Could you fix the first line, too, i.e.:
/*
* ...
> -* CSS-API header file for Advanced Noise Reduction kernel v1
> -*/
> + * CSS-API header file for Advanced Noise Reduction kernel v1
> + */
>
> /* Application specific DMA settings */
> #define ANR_BPP 10
--
Kind regards,
Sakari Ailus
prev parent reply other threads:[~2021-05-26 21:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 11:29 Wan Jiabing
2021-05-26 21:44 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526214431.GJ3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®