From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA1CC47089 for ; Thu, 27 May 2021 13:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B2B0610A2 for ; Thu, 27 May 2021 13:07:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236353AbhE0NIX (ORCPT ); Thu, 27 May 2021 09:08:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236336AbhE0NIW (ORCPT ); Thu, 27 May 2021 09:08:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 151D360FE3; Thu, 27 May 2021 13:06:45 +0000 (UTC) Date: Thu, 27 May 2021 15:06:43 +0200 From: Christian Brauner To: Kees Cook Cc: linux-kernel@vger.kernel.org, Sargun Dhillon , containers@lists.linux.dev, Tycho Andersen , Rodrigo Campos , Mauricio =?utf-8?Q?V=C3=A1squez?= Bernal , Giuseppe Scrivano , =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Andy Lutomirski , Will Drewry Subject: Re: [PATCH] selftests/seccomp: More closely track fds being assigned Message-ID: <20210527130643.zbkcupofjwryjjm5@wittgenstein> References: <20210527032948.3730953-1-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210527032948.3730953-1-keescook@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 26, 2021 at 08:29:48PM -0700, Kees Cook wrote: > Since the open fds might not always start at "4" (especially when > running under kselftest, etc), start counting from the first assigned > fd, rather than using the more permissive EXPECT_GE(fd, 0). > > Signed-off-by: Kees Cook > --- Looks good, Acked-by: Christian Brauner