From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8432DC4708D for ; Fri, 28 May 2021 08:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C676613C9 for ; Fri, 28 May 2021 08:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236210AbhE1IR6 (ORCPT ); Fri, 28 May 2021 04:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235991AbhE1IRz (ORCPT ); Fri, 28 May 2021 04:17:55 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09D9BC06174A for ; Fri, 28 May 2021 01:16:19 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id u13-20020a25f80d0000b029051d7fee31cfso3538859ybd.22 for ; Fri, 28 May 2021 01:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=IGMauNtgVBPGGy8WGv6ECPQxdoO0JVhQLZud2NUEziI=; b=mMBusbY5nzn8Adxs7aCQ7grYRJkTFVN5NBU+4Ps1p0nquDQQkLYt4VfgEzMLCCk+3v 8bh/b+JFWPVel0ZGmZeoNz4trYq8FwjquZxrnEYfpVgZFUfQ3ZPVOXdaTihZ3fYGXxgZ kX7FJl8dEqrT2mmUkO4H1FS0hD8pyKMIJ9LyCmOWVUvRZyUw97SWFIFOQBcX/cphcZaC CLXk3S9Oz3eL/Rbtd8IQti2/0e60Y15puIdg8ST/xeKcCr/Kj2cqizXGITiTy9PWBVhe BbD5bKjlkvCQFRkYNeo9niedT95xHYjHthSXtyeuyDU9CXqhR+JKEtwnpIZfvkSNaVJY Wong== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=IGMauNtgVBPGGy8WGv6ECPQxdoO0JVhQLZud2NUEziI=; b=UhLt58RlDMt+gywVQt6FY3fVc4IsuaykVyKBx9MBnZGWRIS6wj3nj1kQ52VL19sgAf EIWj8qhUlbpme3/XwjCCbYq3zV2Bp6yj/MrX2anaX+8ScHYh1RwwZzqNfRE5HlQ6SvbQ /ZZyajbSwCv6iFqAZxqKmECa6Pr76li6uHD2udxRKDNR/fC1fy9a5+DUQeS9FIaSVS5O au3OvGkgiJ18y1OYvAJ1R2kK7qhrkSTPTCiOTuvOaBFk7gCDnkaBmqPUYlCmUWxKz5jn qSZriPT3uls04jLzBZhbzYZuPw9MSjhBck78/6QrGHtuWwGtn/eXmTi8875dIqQaBgNL 3DnQ== X-Gm-Message-State: AOAM5306jJAVoOLS1ve8oOl7UVbVKWTQD/zREzeE/Fbid2dsaJwTjf+0 mBD0ZL97RN/pMRbXHC4qJeSGK3ktfmIj X-Google-Smtp-Source: ABdhPJw6LaBbL1OT9vwAUCoPFeawkotBh7NLDV/XmImrysOW7+DjvbuPARfM4t8+vTxFVlue7nf9FvCa9h/y X-Received: from kyletso.ntc.corp.google.com ([2401:fa00:fc:202:ce0b:b94c:8a37:2f9]) (user=kyletso job=sendgmr) by 2002:a25:11c5:: with SMTP id 188mr10349086ybr.322.1622189778225; Fri, 28 May 2021 01:16:18 -0700 (PDT) Date: Fri, 28 May 2021 16:16:13 +0800 Message-Id: <20210528081613.730661-1-kyletso@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.rc0.204.g9fa02ecfa5-goog Subject: [PATCH] usb: pd: Set PD_T_SINK_WAIT_CAP to 310ms From: Kyle Tso To: linux@roeck-us.net, gregkh@linuxfoundation.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Current timer PD_T_SINK_WAIT_CAP is set to 240ms which will violate the SinkWaitCapTimer (tTypeCSinkWaitCap 310 - 620 ms) defined in the PD Spec if the port is faster enough when running the state machine. Set it to the lower bound 310ms to ensure the timeout is in Spec. Fixes: f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)") Signed-off-by: Kyle Tso --- include/linux/usb/pd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb/pd.h b/include/linux/usb/pd.h index bf00259493e0..96b7ff66f074 100644 --- a/include/linux/usb/pd.h +++ b/include/linux/usb/pd.h @@ -460,7 +460,7 @@ static inline unsigned int rdo_max_power(u32 rdo) #define PD_T_RECEIVER_RESPONSE 15 /* 15ms max */ #define PD_T_SOURCE_ACTIVITY 45 #define PD_T_SINK_ACTIVITY 135 -#define PD_T_SINK_WAIT_CAP 240 +#define PD_T_SINK_WAIT_CAP 310 /* 310 - 620 ms */ #define PD_T_PS_TRANSITION 500 #define PD_T_SRC_TRANSITION 35 #define PD_T_DRP_SNK 40 -- 2.32.0.rc0.204.g9fa02ecfa5-goog