From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD9AC4708E for ; Fri, 28 May 2021 09:56:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 201D660724 for ; Fri, 28 May 2021 09:56:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236082AbhE1J6M (ORCPT ); Fri, 28 May 2021 05:58:12 -0400 Received: from mga07.intel.com ([134.134.136.100]:64311 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235292AbhE1J6G (ORCPT ); Fri, 28 May 2021 05:58:06 -0400 IronPort-SDR: 7p1Kl/A3ra87q2Or4wNL8ZUAuNcmB8tJobuP4JE800qDsSKRz0ZtB0lcVjKpNmGAXMYTJdEVtd CstySekkotcw== X-IronPort-AV: E=McAfee;i="6200,9189,9997"; a="266814201" X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="266814201" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:56:30 -0700 IronPort-SDR: lHedNBtMjWa7HpWVCW9aObzHnYW23RnXYGsPsppyc6Ei+P04eyzXOHyu8ZfV457u3N4AOaUWI7 wqEwtzQiUwfw== X-IronPort-AV: E=Sophos;i="5.83,229,1616482800"; d="scan'208";a="480985811" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2021 02:56:28 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 09160202F7; Fri, 28 May 2021 12:56:26 +0300 (EEST) Date: Fri, 28 May 2021 12:56:26 +0300 From: Sakari Ailus To: Arnd Bergmann Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans Verkuil , Christoph Hellwig , Andy Shevchenko , Linux Kernel Mailing List , Linux Media Mailing List , linux-staging@lists.linux.dev Subject: Re: [PATCH] media: atomisp: remove compat_ioctl32 code Message-ID: <20210528095625.GO3@paasikivi.fi.intel.com> References: <20210516204818.2967910-1-arnd@kernel.org> <20210524151829.GO3@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 09:19:46AM +0200, Arnd Bergmann wrote: > On Mon, May 24, 2021 at 5:18 PM Sakari Ailus > wrote: > > On Sun, May 16, 2021 at 10:47:43PM +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > This is one of the last remaining users of compat_alloc_user_space() > > > and copy_in_user(), which are in the process of getting removed. > > > > > > As of commit 57e6b6f2303e ("media: atomisp_fops.c: disable > > > atomisp_compat_ioctl32"), nothing in this file is actually getting used > > > as the only reference has been stubbed out. > > > > This patch was made redundant by another one that fixed the bug. But I > > guess you're right in the sense that no-one could have used this because of > > the patch that disabled it. > > > > So: > > > > Acked-by: Sakari Ailus > > > > But: > > > > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c > > > index f1e6b2597853..e383e17c5072 100644 > > > --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c > > > +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c > > > @@ -1283,7 +1283,8 @@ const struct v4l2_file_operations atomisp_fops = { > > > .unlocked_ioctl = video_ioctl2, > > > #ifdef CONFIG_COMPAT > > > /* > > > - * There are problems with this code. Disable this for now. > > > + * this was removed because of bugs, the interface > > > + * needs to be made safe for compat tasks instead. > > > .compat_ioctl32 = atomisp_compat_ioctl32, > > > > I think the comment could go, too. > > Should I replace it with an entry in the TODO file then? On second thought, it's fine. The lack of compat ioctl support is not among the biggest issues anyway. -- Sakari Ailus