From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BEAC47087 for ; Fri, 28 May 2021 12:33:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15E08611BD for ; Fri, 28 May 2021 12:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235098AbhE1MfM (ORCPT ); Fri, 28 May 2021 08:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232310AbhE1MfL (ORCPT ); Fri, 28 May 2021 08:35:11 -0400 Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5451CC061574 for ; Fri, 28 May 2021 05:33:36 -0700 (PDT) Received: by mail-qt1-x831.google.com with SMTP id h21so2542052qtu.5 for ; Fri, 28 May 2021 05:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=dCwmtT3nAJcd/Sp1I1Kz+m3ClrU0NO8l36foJnmNqH4=; b=bMgOqXMmhuJdpkD1fs82u9R6Bxag7whV1pmx9uhNJXypbHElfeqxbyaALqfc+Pa6GS YKcJtX0N0MSKqdCOfZfW5yLo/ChdCoj6PbiKmgvZrOuOY+6jqjfXYp3/X1XUeVB49EIA S9PZV0qIOUrwdB2S9iqlX9eigbTBVEa8i1CrFjH0iYJqCGSozv/GGLtC6TL4XzUEIx1u PRdho5CY4BACwwIuIUtmdSLjUwaV1YdAdhWvYFl0blYzQPOOKo/W1r7YO2ULvB27LaHV MV8+JK4nQ6XSx3nEfKYVlNaxVdjkBpqy15HX9psk4rmHgcOXNJBmG8mtd9UdkGfpcAQA WS3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=dCwmtT3nAJcd/Sp1I1Kz+m3ClrU0NO8l36foJnmNqH4=; b=BDMSiOtURYxHVklm6qdDjRxAa6G7p45ikHNHW4tiXc4bJ1VPzfTTqpQ5vC5Wb1Bgfd 94i3Vk0P5nPOiSKqvbdaMpdkUowiRactQLwdtTmkGetmSi+PTjAwMGse1QQ6uebxmDJF JH9jgLWxHZsrFCD3HZmcU7EOSBzEFIo7fwBoFKqVw0k3Wj4q5BRCctxr8G8QbRTwa69w rq43aCV/cBiXx2hU2hgQ38/WkgtBOE+l+JeJjb9i9j2DoKOk6wuwemvlwuFXocBzXiUC 3sPvIaJ8hv6BwuuyiRfW1/wr7INgHL8qc32BT2RqfQGXYJbPuyHe7t2GbRMNyyj4AKqf yyAw== X-Gm-Message-State: AOAM531Hyr9TOznDc5BLRtLIHiI9kx16HCs9TEuYubdI3AhS/oQQj0Js siqjfg/YusUioXmRN9KdrLIUDg== X-Google-Smtp-Source: ABdhPJwV+8Zujs8IRRSkIAsKUwAGjuV7oJN16GpjqiO308TPIXAlHan8NQfr/MDgRi+yrVF+4Monhw== X-Received: by 2002:a05:622a:18e:: with SMTP id s14mr3249722qtw.200.1622205215536; Fri, 28 May 2021 05:33:35 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-47-55-113-94.dhcp-dynamic.fibreop.ns.bellaliant.net. [47.55.113.94]) by smtp.gmail.com with ESMTPSA id p17sm3402867qkg.67.2021.05.28.05.33.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 May 2021 05:33:35 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1lmbgE-00Fw7P-5G; Fri, 28 May 2021 09:33:34 -0300 Date: Fri, 28 May 2021 09:33:34 -0300 From: Jason Gunthorpe To: YueHaibing Cc: bvanassche@acm.org, dledford@redhat.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 -next] RDMA/srp: use DEVICE_ATTR_*() macro Message-ID: <20210528123334.GI1096940@ziepe.ca> References: <20210528123039.10668-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528123039.10668-1-yuehaibing@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 08:30:39PM +0800, YueHaibing wrote: > @@ -3040,22 +3040,22 @@ static ssize_t show_allow_ext_sg(struct device *dev, > return sysfs_emit(buf, "%s\n", target->allow_ext_sg ? "true" : "false"); > } > > -static DEVICE_ATTR(id_ext, S_IRUGO, show_id_ext, NULL); > -static DEVICE_ATTR(ioc_guid, S_IRUGO, show_ioc_guid, NULL); > -static DEVICE_ATTR(service_id, S_IRUGO, show_service_id, NULL); > -static DEVICE_ATTR(pkey, S_IRUGO, show_pkey, NULL); > -static DEVICE_ATTR(sgid, S_IRUGO, show_sgid, NULL); > -static DEVICE_ATTR(dgid, S_IRUGO, show_dgid, NULL); > -static DEVICE_ATTR(orig_dgid, S_IRUGO, show_orig_dgid, NULL); > -static DEVICE_ATTR(req_lim, S_IRUGO, show_req_lim, NULL); > -static DEVICE_ATTR(zero_req_lim, S_IRUGO, show_zero_req_lim, NULL); > -static DEVICE_ATTR(local_ib_port, S_IRUGO, show_local_ib_port, NULL); > -static DEVICE_ATTR(local_ib_device, S_IRUGO, show_local_ib_device, NULL); > -static DEVICE_ATTR(ch_count, S_IRUGO, show_ch_count, NULL); > -static DEVICE_ATTR(comp_vector, S_IRUGO, show_comp_vector, NULL); > -static DEVICE_ATTR(tl_retry_count, S_IRUGO, show_tl_retry_count, NULL); > -static DEVICE_ATTR(cmd_sg_entries, S_IRUGO, show_cmd_sg_entries, NULL); > -static DEVICE_ATTR(allow_ext_sg, S_IRUGO, show_allow_ext_sg, NULL); > +static DEVICE_ATTR_RO(id_ext); > +static DEVICE_ATTR_RO(ioc_guid); > +static DEVICE_ATTR_RO(service_id); > +static DEVICE_ATTR_RO(pkey); > +static DEVICE_ATTR_RO(sgid); > +static DEVICE_ATTR_RO(dgid); > +static DEVICE_ATTR_RO(orig_dgid); > +static DEVICE_ATTR_RO(req_lim); > +static DEVICE_ATTR_RO(zero_req_lim); > +static DEVICE_ATTR_RO(local_ib_port); > +static DEVICE_ATTR_RO(local_ib_device); > +static DEVICE_ATTR_RO(ch_count); > +static DEVICE_ATTR_RO(comp_vector); > +static DEVICE_ATTR_RO(tl_retry_count); > +static DEVICE_ATTR_RO(cmd_sg_entries); > +static DEVICE_ATTR_RO(allow_ext_sg); can you also organize this so the ATTR's are placed after their functions, as is normal? Thanks, Jason