From: Jarmo Tiitto <jarmo.tiitto@gmail.com>
To: samitolvanen@google.com
Cc: wcw@google.com, nathan@kernel.org, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com,
Jarmo Tiitto <jarmo.tiitto@gmail.com>
Subject: [PATCH 5/6] pgo: modules Fixup memory leak.
Date: Fri, 28 May 2021 23:11:07 +0300 [thread overview]
Message-ID: <20210528201107.459362-1-jarmo.tiitto@gmail.com> (raw)
Signed-off-by: Jarmo Tiitto <jarmo.tiitto@gmail.com>
---
kernel/pgo/fs_mod.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/pgo/fs_mod.c b/kernel/pgo/fs_mod.c
index 0808d44227f1..2d1ff99e7982 100644
--- a/kernel/pgo/fs_mod.c
+++ b/kernel/pgo/fs_mod.c
@@ -261,6 +261,8 @@ static int prf_module_open(struct inode *inode, struct file *file)
if (!pinfo->buffer) {
err = -ENOMEM;
+ kfree(pinfo);
+ module_put(mod);
goto out;
}
}
@@ -373,7 +375,7 @@ static int pgo_module_notifier(struct notifier_block *nb, unsigned long event,
if (strcmp(data->mod->name, mod->name) == 0) {
mutex_lock(&prf_mod_lock);
- /* remofe from profiled modules */
+ /* remove from profiled modules */
list_del_rcu(&data->link);
/* mark it stale */
WRITE_ONCE(data->mod, NULL);
--
2.31.1
next reply other threads:[~2021-05-28 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 20:11 Jarmo Tiitto [this message]
2021-05-31 18:20 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528201107.459362-1-jarmo.tiitto@gmail.com \
--to=jarmo.tiitto@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=samitolvanen@google.com \
--cc=wcw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®