From: Navin Sankar Velliangiri <navin@linumiz.com>
To: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com, navin@linumiz.com
Subject: [PATCH] hid: hid-chicony: fix switch case indentation
Date: Sat, 29 May 2021 12:48:08 +0530 [thread overview]
Message-ID: <20210529071808.5268-1-navin@linumiz.com> (raw)
fixed switch case indentation.
Block comments should not use a trailing */ on a separate line.
Reported by checkpatch.
Signed-off-by: Navin Sankar Velliangiri <navin@linumiz.com>
---
drivers/hid/hid-chicony.c | 74 +++++++++++++++++++++++++++++----------
1 file changed, 55 insertions(+), 19 deletions(-)
diff --git a/drivers/hid/hid-chicony.c b/drivers/hid/hid-chicony.c
index ca556d39da2a..7dd4cfd256d9 100644
--- a/drivers/hid/hid-chicony.c
+++ b/drivers/hid/hid-chicony.c
@@ -65,26 +65,61 @@ static int ch_input_mapping(struct hid_device *hdev, struct hid_input *hi,
set_bit(EV_REP, hi->input->evbit);
switch (usage->hid & HID_USAGE) {
- case 0xff01: ch_map_key_clear(BTN_1); break;
- case 0xff02: ch_map_key_clear(BTN_2); break;
- case 0xff03: ch_map_key_clear(BTN_3); break;
- case 0xff04: ch_map_key_clear(BTN_4); break;
- case 0xff05: ch_map_key_clear(BTN_5); break;
- case 0xff06: ch_map_key_clear(BTN_6); break;
- case 0xff07: ch_map_key_clear(BTN_7); break;
- case 0xff08: ch_map_key_clear(BTN_8); break;
- case 0xff09: ch_map_key_clear(BTN_9); break;
- case 0xff0a: ch_map_key_clear(BTN_A); break;
- case 0xff0b: ch_map_key_clear(BTN_B); break;
- case 0x00f1: ch_map_key_clear(KEY_WLAN); break;
- case 0x00f2: ch_map_key_clear(KEY_BRIGHTNESSDOWN); break;
- case 0x00f3: ch_map_key_clear(KEY_BRIGHTNESSUP); break;
- case 0x00f4: ch_map_key_clear(KEY_DISPLAY_OFF); break;
- case 0x00f7: ch_map_key_clear(KEY_CAMERA); break;
- case 0x00f8: ch_map_key_clear(KEY_PROG1); break;
+ case 0xff01:
+ ch_map_key_clear(BTN_1);
+ break;
+ case 0xff02:
+ ch_map_key_clear(BTN_2);
+ break;
+ case 0xff03:
+ ch_map_key_clear(BTN_3);
+ break;
+ case 0xff04:
+ ch_map_key_clear(BTN_4);
+ break;
+ case 0xff05:
+ ch_map_key_clear(BTN_5);
+ break;
+ case 0xff06:
+ ch_map_key_clear(BTN_6);
+ break;
+ case 0xff07:
+ ch_map_key_clear(BTN_7);
+ break;
+ case 0xff08:
+ ch_map_key_clear(BTN_8);
+ break;
+ case 0xff09:
+ ch_map_key_clear(BTN_9);
+ break;
+ case 0xff0a:
+ ch_map_key_clear(BTN_A);
+ break;
+ case 0xff0b:
+ ch_map_key_clear(BTN_B);
+ break;
+ case 0x00f1:
+ ch_map_key_clear(KEY_WLAN);
+ break;
+ case 0x00f2:
+ ch_map_key_clear(KEY_BRIGHTNESSDOWN);
+ break;
+ case 0x00f3:
+ ch_map_key_clear(KEY_BRIGHTNESSUP);
+ break;
+ case 0x00f4:
+ ch_map_key_clear(KEY_DISPLAY_OFF);
+ break;
+ case 0x00f7:
+ ch_map_key_clear(KEY_CAMERA);
+ break;
+ case 0x00f8:
+ ch_map_key_clear(KEY_PROG1);
+ break;
default:
return 0;
}
+
return 1;
}
@@ -92,10 +127,11 @@ static __u8 *ch_switch12_report_fixup(struct hid_device *hdev, __u8 *rdesc,
unsigned int *rsize)
{
struct usb_interface *intf = to_usb_interface(hdev->dev.parent);
-
+
if (intf->cur_altsetting->desc.bInterfaceNumber == 1) {
/* Change usage maximum and logical maximum from 0x7fff to
- * 0x2fff, so they don't exceed HID_MAX_USAGES */
+ * 0x2fff, so they don't exceed HID_MAX_USAGES
+ */
switch (hdev->product) {
case USB_DEVICE_ID_CHICONY_ACER_SWITCH12:
if (*rsize >= 128 && rdesc[64] == 0xff && rdesc[65] == 0x7f
--
2.31.1
next reply other threads:[~2021-05-29 7:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 7:18 Navin Sankar Velliangiri [this message]
2021-05-29 7:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210529071808.5268-1-navin@linumiz.com \
--to=navin@linumiz.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®