From: Lee Jones <lee.jones@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: linux-kernel@vger.kernel.org,
Carl Philipp Klemm <philipp@uvos.xyz>,
Ivan Jelincic <parazyd@dyne.org>,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
"Sicelo A . Mhlongo" <absicsz@gmail.com>
Subject: Re: [PATCH] mfd: cpcap: Fix cpcap dmamask not set warnings
Date: Tue, 1 Jun 2021 15:55:40 +0100 [thread overview]
Message-ID: <20210601145540.GM543307@dell> (raw)
In-Reply-To: <20210522051001.53060-1-tony@atomide.com>
On Sat, 22 May 2021, Tony Lindgren wrote:
> We have started to get a bunch of pointless dmamask not set warnings
> that makes the output of dmesg -l err,warn hard to read with many
> extra warnings:
>
> cpcap-regulator cpcap-regulator.0: DMA mask not set
> cpcap_adc cpcap_adc.0: DMA mask not set
> cpcap_battery cpcap_battery.0: DMA mask not set
> cpcap-charger cpcap-charger.0: DMA mask not set
> cpcap-pwrbutton cpcap-pwrbutton.0: DMA mask not set
> cpcap-led cpcap-led.0: DMA mask not set
> cpcap-led cpcap-led.1: DMA mask not set
> cpcap-led cpcap-led.2: DMA mask not set
> cpcap-led cpcap-led.3: DMA mask not set
> cpcap-led cpcap-led.4: DMA mask not set
> cpcap-rtc cpcap-rtc.0: DMA mask not set
> cpcap-usb-phy cpcap-usb-phy.0: DMA mask not set
>
> This seems to have started with commit 4d8bde883bfb ("OF: Don't set
> default coherent DMA mask"). We have the parent SPI controller use
> DMA, while CPCAP driver and it's children do not. For audio, the
> DMA is handled over I2S bus with the McBSP driver.
>
> Cc: Carl Philipp Klemm <philipp@uvos.xyz>
> Cc: Ivan Jelincic <parazyd@dyne.org>
> Cc: Merlijn Wajer <merlijn@wizzup.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Sebastian Reichel <sre@kernel.org>
> Cc: Sicelo A. Mhlongo <absicsz@gmail.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/mfd/motorola-cpcap.c | 4 ++++
> 1 file changed, 4 insertions(+)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2021-06-01 14:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 5:10 Tony Lindgren
2021-06-01 14:55 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601145540.GM543307@dell \
--to=lee.jones@linaro.org \
--cc=absicsz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=parazyd@dyne.org \
--cc=pavel@ucw.cz \
--cc=philipp@uvos.xyz \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®