From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA1E1C47096 for ; Thu, 3 Jun 2021 15:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAB6F61208 for ; Thu, 3 Jun 2021 15:41:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230178AbhFCPmw (ORCPT ); Thu, 3 Jun 2021 11:42:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:49034 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229878AbhFCPmv (ORCPT ); Thu, 3 Jun 2021 11:42:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622734866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AvsQH1hyQpvPjHL2hTxdfQHPQhfR4l9xQwXErWo9HxI=; b=XtU0eqVa2mWhphEmu1GQCZZvR9Jvo+q4rC5u8AYKXwnvZMr+RohZAQBtYqMCEiDhRXd6KN NtHBJt4w3RdpKDsGRRdo73wZ6DnzE+Me4mtnVKhUdbHnkCoM2B4YqWu/CsdurGqRV3uUb+ p1AXBbWi08/OVxMNAuo8gh26/leRvxc= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-477-peGmwcWTMVWp3sOszJTZ1w-1; Thu, 03 Jun 2021 11:41:04 -0400 X-MC-Unique: peGmwcWTMVWp3sOszJTZ1w-1 Received: by mail-ej1-f72.google.com with SMTP id nd10-20020a170907628ab02903a324b229bfso2112546ejc.7 for ; Thu, 03 Jun 2021 08:41:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AvsQH1hyQpvPjHL2hTxdfQHPQhfR4l9xQwXErWo9HxI=; b=m4M4tLQ8t/63GDy6M0hS0k7bPsedV4XrhAHJ5gi11kjBipSTyyoNyspjcpUgyvgNXj XU3hHmWBbya2eh3E9ruXiCICpoZvIXC8arL1av25IBAjLEiQTM684/OXvOAdrIRoJhAk g9EdoSDWMs/6iOrKM74Rxk+4bi7YzVufXc83WFBx3bM8/fvSAsRyQgX5wpDEsoeAjWnt LHRjrc4FTHT+9dloGr4BxGhiAp8hPNsfgvbXpPmf28YLBQxdKW36SEHUYn/A8xeC+gmz K+MWZYsJzCJpjS1zeJr42tUc5iNmF6+tFpSGw+P3p8wisLeTs6Ujx95lVksvgwnZypYw dGrA== X-Gm-Message-State: AOAM533YJHAsyl6bZKRV3yiRMDf3Kv00CiuJNtFxVjltL38mGGPBePm/ +pJeGAjhczbXg74AKgJANVYlwcVd+6uzN8GvFqZIPkLMbxWbC0o7tdk0EPCiA0gRnTDwci4596c mv7qo7bDlaReChpYc5LWG5kx8 X-Received: by 2002:a05:6402:4313:: with SMTP id m19mr80401edc.263.1622734860914; Thu, 03 Jun 2021 08:41:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyY5YQ/utrtbJ0+zixQqmqhNKVQZErmThRj2KcDrDwxrmJQ2oZwOP9DefrKyZY+3MYgkheR+g== X-Received: by 2002:a05:6402:4313:: with SMTP id m19mr80384edc.263.1622734860773; Thu, 03 Jun 2021 08:41:00 -0700 (PDT) Received: from steredhat ([5.170.129.82]) by smtp.gmail.com with ESMTPSA id l8sm1930416edt.69.2021.06.03.08.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 08:41:00 -0700 (PDT) Date: Thu, 3 Jun 2021 17:40:56 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Steven Rostedt , Ingo Molnar , Jorgen Hansen , Norbert Slusarek , Colin Ian King , Andra Paraschiv , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com Subject: Re: [PATCH v10 18/18] virtio/vsock: update trace event for SEQPACKET Message-ID: <20210603154056.e3zyk2wmmutq4nia@steredhat> References: <20210520191357.1270473-1-arseny.krasnov@kaspersky.com> <20210520192008.1272910-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210520192008.1272910-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 20, 2021 at 10:20:04PM +0300, Arseny Krasnov wrote: >Add SEQPACKET socket type to vsock trace event. > >Signed-off-by: Arseny Krasnov >--- > include/trace/events/vsock_virtio_transport_common.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/include/trace/events/vsock_virtio_transport_common.h b/include/trace/events/vsock_virtio_transport_common.h >index 6782213778be..b30c0e319b0e 100644 >--- a/include/trace/events/vsock_virtio_transport_common.h >+++ b/include/trace/events/vsock_virtio_transport_common.h >@@ -9,9 +9,12 @@ > #include > > TRACE_DEFINE_ENUM(VIRTIO_VSOCK_TYPE_STREAM); >+TRACE_DEFINE_ENUM(VIRTIO_VSOCK_TYPE_SEQPACKET); > > #define show_type(val) \ >- __print_symbolic(val, { VIRTIO_VSOCK_TYPE_STREAM, "STREAM" }) >+ __print_symbolic(val, \ >+ { VIRTIO_VSOCK_TYPE_STREAM, "STREAM" }, \ >+ { VIRTIO_VSOCK_TYPE_SEQPACKET, "SEQPACKET" }) I think we should fixe the indentation here (e.g. following show_op): #define show_type(val) \ __print_symbolic(val, \ { VIRTIO_VSOCK_TYPE_STREAM, "STREAM" }, \ { VIRTIO_VSOCK_TYPE_SEQPACKET, "SEQPACKET" }) Thanks, Stefano > > TRACE_DEFINE_ENUM(VIRTIO_VSOCK_OP_INVALID); > TRACE_DEFINE_ENUM(VIRTIO_VSOCK_OP_REQUEST); >-- >2.25.1 >