From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99B6C4708F for ; Fri, 4 Jun 2021 09:27:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 908E06140B for ; Fri, 4 Jun 2021 09:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229980AbhFDJ33 (ORCPT ); Fri, 4 Jun 2021 05:29:29 -0400 Received: from mail-ed1-f54.google.com ([209.85.208.54]:38759 "EHLO mail-ed1-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229958AbhFDJ31 (ORCPT ); Fri, 4 Jun 2021 05:29:27 -0400 Received: by mail-ed1-f54.google.com with SMTP id o5so10377147edc.5 for ; Fri, 04 Jun 2021 02:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v4s7Wdp9P+q1iZfuGGxYhUoU58bq9Dm8LlurM2nZ904=; b=IbVRCbVi0TMLMZSOQCIoI6xN2Rk8hy4/iQ7Vg+2pMSUrilCtVQDK6uK6OyCqxzGLKW WdR5yT9nqflcvKcaHipGwqPpuU6t9iVvTPHF6HnQGtfAE3h5SBxQFZlmqcRkMB+DN+sk 0G9TVefGF74xLo8BqBWJxN48XMpcg8fjfMJv8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=v4s7Wdp9P+q1iZfuGGxYhUoU58bq9Dm8LlurM2nZ904=; b=uFOZCDoBRqRSxsqhNd8YR2rF21cFK7WTT/21hMyN+Bf1RPTPp8bDAqwY97HUiDc3N0 mrD79z3pTEUOLrNHBvNu1VSm6RIyzVXze03fO2i2w7Q3Zs5O67e+Z0ih5700mCBztzyq YQUqrhZ/B2VzV4QOq1hKYS7o5W3QMqWzzVXGrGVF8nmVX+/tqaLVg/q5UQ+8A5puFxpz Jy9mJLOu+LDa/RDQQYbs9EcNP0wewmwLlePvdSVKDmrD3WQfI0qsTbjI/KG90jPfXLO2 idbhRDY3L+WqrZBfME0XKwYNagdJNboK/fXR/+UMtcslq6O0RD8EBAfWmm2vsr/omUIx sp6w== X-Gm-Message-State: AOAM533N8l6IGIILXiaQTiQ0vytpYdixsvmq+K5NK3gvpMPMFmhwl80j pSndfBRxvb/pxEWkbUfW42SUbCm/5z7Oc0iG X-Google-Smtp-Source: ABdhPJyjZP8jlD/L9dViQFhwyi+cx1pz4rYhELSDTRpINtaExQYPqWEEcFK54K4RKtSCzFSQLh2rxQ== X-Received: by 2002:aa7:db90:: with SMTP id u16mr3695449edt.106.1622798800833; Fri, 04 Jun 2021 02:26:40 -0700 (PDT) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id z22sm2095405ejm.71.2021.06.04.02.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 02:26:40 -0700 (PDT) From: Ricardo Ribalda To: linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo Cc: Ricardo Ribalda Subject: [PATCH] tools/perf: Do not set a variable unless it will be used Date: Fri, 4 Jun 2021 11:26:38 +0200 Message-Id: <20210604092638.985694-1-ribalda@chromium.org> X-Mailer: git-send-email 2.32.0.rc1.229.g3e70b5a671-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org clang-13 triggers the following warning: bench/inject-buildid.c:351:6: error: variable 'len' set but not used [-Werror,-Wunused-but-set-variable] u64 len = 0; This patch sets the value to len only if it will be used afterwards. Signed-off-by: Ricardo Ribalda --- tools/perf/bench/inject-buildid.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/perf/bench/inject-buildid.c b/tools/perf/bench/inject-buildid.c index 55d373b75791..fee69ac787b2 100644 --- a/tools/perf/bench/inject-buildid.c +++ b/tools/perf/bench/inject-buildid.c @@ -348,13 +348,13 @@ static int inject_build_id(struct bench_data *data, u64 *max_rss) int status; unsigned int i, k; struct rusage rusage; - u64 len = 0; + u64 len; /* this makes the child to run */ if (perf_header__write_pipe(data->input_pipe[1]) < 0) return -1; - len += synthesize_attr(data); + len = synthesize_attr(data); len += synthesize_fork(data); for (i = 0; i < nr_mmaps; i++) { -- 2.32.0.rc1.229.g3e70b5a671-goog