From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9172C07E94 for ; Fri, 4 Jun 2021 10:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB91F613AD for ; Fri, 4 Jun 2021 10:09:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229810AbhFDKL0 (ORCPT ); Fri, 4 Jun 2021 06:11:26 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3429 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhFDKLZ (ORCPT ); Fri, 4 Jun 2021 06:11:25 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FxJML4CfRz6txr for ; Fri, 4 Jun 2021 18:06:38 +0800 (CST) Received: from dggemi758-chm.china.huawei.com (10.1.198.144) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Fri, 4 Jun 2021 18:09:38 +0800 Received: from huawei.com (10.175.101.6) by dggemi758-chm.china.huawei.com (10.1.198.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Fri, 4 Jun 2021 18:09:37 +0800 From: ChenXiaoSong CC: , , , Subject: [PATCH -next] PCI: al: Remove redundant dev_err call in al_pcie_probe() Date: Fri, 4 Jun 2021 18:16:00 +0800 Message-ID: <20210604101600.3658139-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.25.4 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggemi758-chm.china.huawei.com (10.1.198.144) X-CFilter-Loop: Reflected To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Reported-by: Hulk Robot Signed-off-by: ChenXiaoSong --- drivers/pci/controller/dwc/pcie-al.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-al.c b/drivers/pci/controller/dwc/pcie-al.c index e8afa50129a8..fb4d1eed07ce 100644 --- a/drivers/pci/controller/dwc/pcie-al.c +++ b/drivers/pci/controller/dwc/pcie-al.c @@ -346,11 +346,8 @@ static int al_pcie_probe(struct platform_device *pdev) controller_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "controller"); al_pcie->controller_base = devm_ioremap_resource(dev, controller_res); - if (IS_ERR(al_pcie->controller_base)) { - dev_err(dev, "couldn't remap controller base %pR\n", - controller_res); + if (IS_ERR(al_pcie->controller_base)) return PTR_ERR(al_pcie->controller_base); - } dev_dbg(dev, "From DT: controller_base: %pR\n", controller_res); -- 2.25.4