From: Baokun Li <libaokun1@huawei.com>
To: <linux-kernel@vger.kernel.org>
Cc: <weiyongjun1@huawei.com>, <yuehaibing@huawei.com>,
<yangjihong1@huawei.com>, <yukuai3@huawei.com>,
<libaokun1@huawei.com>
Subject: [PATCH -next] devpts: fix doc warnings in inode.c
Date: Sat, 5 Jun 2021 14:32:35 +0800 [thread overview]
Message-ID: <20210605063235.682889-1-libaokun1@huawei.com> (raw)
Fixes the following W=1 kernel build warning(s):
fs/devpts/inode.c:563: warning:
Function parameter or member 'fsi' not described in 'devpts_pty_new'
fs/devpts/inode.c:563: warning:
Excess function parameter 'ptmx_inode' description in 'devpts_pty_new'
fs/devpts/inode.c:563: warning:
Excess function parameter 'device' description in 'devpts_pty_new'
fs/devpts/inode.c:606: warning:
Function parameter or member 'dentry' not described in 'devpts_get_priv'
fs/devpts/inode.c:606: warning:
Excess function parameter 'pts_inode' description in 'devpts_get_priv'
fs/devpts/inode.c:619: warning:
Function parameter or member 'dentry' not described in 'devpts_pty_kill'
fs/devpts/inode.c:619: warning:
Excess function parameter 'inode' description in 'devpts_pty_kill'
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
fs/devpts/inode.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/devpts/inode.c b/fs/devpts/inode.c
index 42e5a766d33c..d739f1b303f4 100644
--- a/fs/devpts/inode.c
+++ b/fs/devpts/inode.c
@@ -552,8 +552,7 @@ void devpts_kill_index(struct pts_fs_info *fsi, int idx)
/**
* devpts_pty_new -- create a new inode in /dev/pts/
- * @ptmx_inode: inode of the master
- * @device: major+minor of the node to be created
+ * @fsi: pointer to pts_fs_info
* @index: used as a name of the node
* @priv: what's given back by devpts_get_priv
*
@@ -598,7 +597,7 @@ struct dentry *devpts_pty_new(struct pts_fs_info *fsi, int index, void *priv)
/**
* devpts_get_priv -- get private data for a slave
- * @pts_inode: inode of the slave
+ * @dentry: dentry of the slave
*
* Returns whatever was passed as priv in devpts_pty_new for a given inode.
*/
@@ -611,7 +610,7 @@ void *devpts_get_priv(struct dentry *dentry)
/**
* devpts_pty_kill -- remove inode form /dev/pts/
- * @inode: inode of the slave to be removed
+ * @dentry: dentry of the slave to be removed
*
* This is an inverse operation of devpts_pty_new.
*/
--
2.31.1
reply other threads:[~2021-06-05 6:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210605063235.682889-1-libaokun1@huawei.com \
--to=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®