From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D59C47096 for ; Sun, 6 Jun 2021 03:40:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F3CD461380 for ; Sun, 6 Jun 2021 03:40:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230112AbhFFDmd (ORCPT ); Sat, 5 Jun 2021 23:42:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbhFFDmc (ORCPT ); Sat, 5 Jun 2021 23:42:32 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E96C0C061766 for ; Sat, 5 Jun 2021 20:40:43 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id d13so2416595edt.5 for ; Sat, 05 Jun 2021 20:40:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gD8GyiAl/H+wS42xF/dTntBfAP6bsJgpIEJdko9JNos=; b=KgL6TvXFrfSYf2mXOkY18UYYwPE9wSx1hVoJQp4nA093VryYKKDbfOGGxwTuyCymWc mnrPqTfB/sGi2HjH9gR7fzYJ7YK6lBdFfFnd0nPCEFovPqbQ9MnwPGuevjyRmpEDyEko cvn2DEGJoe1ftY+uFzaQvt9RsTXTqztTh0Ta1u/+WLm1S+pyLL6LJpAo1zElpegY7vrT nsESb6Jj50RK49rOKbF0CJa9IrazmLfMKImNyA1HZNCyp6Karxrn/YpgWcvBdYm9bpFK 2t9WHbjyiAkkhoTOrxRB67ctT3S4mSzJB/aUiu+rmDfvRw6vHH/rL0gAuVyYPrhbPkxD zvVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=gD8GyiAl/H+wS42xF/dTntBfAP6bsJgpIEJdko9JNos=; b=b2OjPsVsySpQ0jFCwbaqDTSFq2UnUvP6D8BcqsEDVAlOar7GKU72CDJMtekUA8CURu 4mpHKOJR/ddVAtF0ZENMttkC3PD12ELf/DPeW3c/7/4Ltr/1dk/r7cRCZz2S39yOko+r is/kpk0hQoq8VG73DuDGRCzbbpEDgaiTPMzrsdN7rqBHQ7UJXu6WZeHCHPEBB4nKJdl8 WaD4tv1Hh2kRsNa0ES8SB5kS7XImxQDveUEsllb+c4+Zz3mHVRIeolrCDA6Pt0A1an87 UhKSjc5CLZL+TpYYWiDxoaEraQq6IFuFG1wamUzhTaJRWnMQiFKk+oKzxyL3k+649A8P wNPg== X-Gm-Message-State: AOAM530WCCL0dLk/3whflUkTnwyUT9Dk5Tgu61u9hUrHd3nBwde6DGSC y2sZSjgqZZLGhnZQ1kOOJFA= X-Google-Smtp-Source: ABdhPJxx0T9AquvpjLUbFiwTW0g9PlgIjZoGh5kw+Q6Lz+Oa2GA0Slx2OEeTnL9fgUc09GSL6o436w== X-Received: by 2002:a05:6402:487:: with SMTP id k7mr12998011edv.315.1622950842534; Sat, 05 Jun 2021 20:40:42 -0700 (PDT) Received: from linux.local (host-82-59-55-132.retail.telecomitalia.it. [82.59.55.132]) by smtp.gmail.com with ESMTPSA id zg9sm2814845ejb.116.2021.06.05.20.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Jun 2021 20:40:42 -0700 (PDT) From: "Fabio M. De Francesco" To: Larry Finger , Florian Schilhabel , Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: "Fabio M. De Francesco" Subject: [PATCH] staging: rtl8712: Remove unnecessary alias of printk() Date: Sun, 6 Jun 2021 05:40:38 +0200 Message-Id: <20210606034038.9657-1-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This module defines four alias for printk(). Removed them all, because they are not used anywhere else in the driver. Converted the only exception to the explicit use of printk(). Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- drivers/staging/rtl8712/rtl871x_debug.h | 23 ----------------------- 2 files changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_cmd.c b/drivers/staging/rtl8712/rtl8712_cmd.c index ff3cb09c57a6..e94604cb71fd 100644 --- a/drivers/staging/rtl8712/rtl8712_cmd.c +++ b/drivers/staging/rtl8712/rtl8712_cmd.c @@ -55,7 +55,7 @@ static void check_hw_pbc(struct _adapter *padapter) /* Here we only set bPbcPressed to true * After trigger PBC, the variable will be set to false */ - DBG_8712("CheckPbcGPIO - PBC is pressed !!!!\n"); + printk(KERN_DEBUG "CheckPbcGPIO - PBC is pressed !!!!\n"); /* 0 is the default value and it means the application monitors * the HW PBC doesn't provide its pid to driver. */ diff --git a/drivers/staging/rtl8712/rtl871x_debug.h b/drivers/staging/rtl8712/rtl871x_debug.h index 57f2a38cb71c..69c631af2a2a 100644 --- a/drivers/staging/rtl8712/rtl871x_debug.h +++ b/drivers/staging/rtl8712/rtl871x_debug.h @@ -127,27 +127,4 @@ #undef _MODULE_DEFINE_ #endif -#define _dbgdump printk - -#define MSG_8712(x, ...) {} - -#define DBG_8712(x, ...) {} - -#define WRN_8712(x, ...) {} - -#define ERR_8712(x, ...) {} - -#undef MSG_8712 -#define MSG_8712 _dbgdump - -#undef DBG_8712 -#define DBG_8712 _dbgdump - -#undef WRN_8712 -#define WRN_8712 _dbgdump - -#undef ERR_8712 -#define ERR_8712 _dbgdump - #endif /*__RTL871X_DEBUG_H__*/ - -- 2.31.1