From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7861C47082 for ; Mon, 7 Jun 2021 06:23:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA2AA611BD for ; Mon, 7 Jun 2021 06:23:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230284AbhFGGYu convert rfc822-to-8bit (ORCPT ); Mon, 7 Jun 2021 02:24:50 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:34155 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230265AbhFGGYu (ORCPT ); Mon, 7 Jun 2021 02:24:50 -0400 Received: (Authenticated sender: miquel.raynal@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id A512C20002; Mon, 7 Jun 2021 06:22:56 +0000 (UTC) Date: Mon, 7 Jun 2021 08:22:55 +0200 From: Miquel Raynal To: Yang Yingliang Cc: , , Subject: Re: [PATCH -next v2] i3c: master: svc: drop free_irq of devm_request_irq allocated irq Message-ID: <20210607082255.5ab761b9@xps13> In-Reply-To: <20210602084935.3977636-1-yangyingliang@huawei.com> References: <20210602084935.3977636-1-yangyingliang@huawei.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.7 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Yang Yingliang wrote on Wed, 2 Jun 2021 16:49:35 +0800: > irq allocated with devm_request_irq() will be freed in devm_irq_release(), > using free_irq() in ->remove() will causes a dangling pointer, and a > subsequent double free. So remove the free_irq() in svc_i3c_master_remove(). > > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Reviewed-by: Miquel Raynal Thanks, Miquèl