From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAA91C47082 for ; Mon, 7 Jun 2021 16:29:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8104361C7A for ; Mon, 7 Jun 2021 16:29:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbhFGQbS (ORCPT ); Mon, 7 Jun 2021 12:31:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:60162 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234136AbhFGQZY (ORCPT ); Mon, 7 Jun 2021 12:25:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21B9A6196E; Mon, 7 Jun 2021 16:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623082577; bh=vn/UDLU2muWr/uJ/R2960xAjhebQsbHwhNrylMHr1Yw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UyD3g/loNcVBrfXGEI/ozM4KP2m4RVBn1SodIMgX3O13LLdtjNWqw1E8iZ/z1ZJ/Q YeslAEJmp3RRp5YInkydi6bAh2VPsH6WoiSTWsejfctvjRmyR8i6FlY+1Q8Zp42eMY G6Sf/RRk6TgES2/4I3lwWTskyBydtnQs8fFjxoOYffrUKCjEG9EDJjaf2IsMiXVNpe OgXdwGH6jTidqhELvesF86Iv39kJKa6qX3UOMX3FGO7sz69z/3uSrMd5Qx6ZN3NwG4 nl5zqExD1djIFD3owUbmXVAa8GWCIc3C3OtJToWBfTNGISzpz1HI3aniBZRrhv9tAB mWVK3pgJR8C/A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jiapeng Chong , Abaci Robot , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.4 09/14] ethernet: myri10ge: Fix missing error code in myri10ge_probe() Date: Mon, 7 Jun 2021 12:16:00 -0400 Message-Id: <20210607161605.3584954-9-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210607161605.3584954-1-sashal@kernel.org> References: <20210607161605.3584954-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiapeng Chong [ Upstream commit f336d0b93ae978f12c5e27199f828da89b91e56a ] The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'status'. Eliminate the follow smatch warning: drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe() warn: missing error code 'status'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index 8ebf3611aba3..9ecb99a1de35 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -4051,6 +4051,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent) dev_err(&pdev->dev, "invalid sram_size %dB or board span %ldB\n", mgp->sram_size, mgp->board_span); + status = -EINVAL; goto abort_with_ioremap; } memcpy_fromio(mgp->eeprom_strings, -- 2.30.2