From: Ulf Hansson <ulf.hansson@linaro.org>
To: "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-pm@vger.kernel.org
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Saravana Kannan <saravanak@google.com>,
Alan Stern <stern@rowland.harvard.edu>,
Adrian Hunter <adrian.hunter@intel.com>,
Tony Lindgren <tony@atomide.com>,
Kevin Hilman <khilman@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 0/3] PM: runtime: Update behaviour for no callbacks
Date: Tue, 8 Jun 2021 11:02:47 +0200 [thread overview]
Message-ID: <20210608090250.85256-1-ulf.hansson@linaro.org> (raw)
While reviewing a patch on the mmc-list, I ended up inspecting the behaviour of
how we deal with the no callback case for runtime PM.
A couple of observations:
*) When pm_runtime_no_callbacks() have been called, it allows the PM core to
takes a quicker path, but at the same time, consumer/supplier device links are
being skipped in rpm_resume|suspend().
**) Calling pm_runtime_no_callbacks() to avoid boiler plate code (assigning
empty functions to ->runtime_suspend|resume()), doesn't work if there could be
consumer/supplier device link being used or a platform dependent PM domain that
could get attached to the device.
Therefore, this series suggests to change the behaviour in the PM core, to
allow the ->runtime_suspend|resume() callbacks to be unassigned. This is already
supported for ->runtime_idle() callbacks, so it would also move things into a
more consistent behaviour.
I have looked at various error paths, in the kernel of callers of
pm_runtime_get_sync(). I couldn't find anyone that made sense, that looked for
the special error code, -ENOSYS, which is the error code getting returned when a
callback is missing. Whether that is sufficient proof that these changes are
100% safe, I can't guarantee, but I think it would be worth a try as the
benefits of avoiding boilerplate code and the corresponding additional code
paths are quite nice, if you ask me.
Kind regards
Ulf Hansson
Ulf Hansson (3):
PM: runtime: Improve path in rpm_idle() when no callback
PM: runtime: Allow unassigned ->runtime_suspend|resume callbacks
PM: runtime: Clarify documentation when callbacks are unassigned
Documentation/power/runtime_pm.rst | 8 ++++++++
drivers/base/power/runtime.c | 18 ++++++++----------
2 files changed, 16 insertions(+), 10 deletions(-)
--
2.25.1
next reply other threads:[~2021-06-08 9:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 9:02 Ulf Hansson [this message]
2021-06-08 9:02 ` [PATCH v2 1/3] PM: runtime: Improve path in rpm_idle() when no callback Ulf Hansson
2021-06-08 9:02 ` [PATCH v2 2/3] PM: runtime: Allow unassigned ->runtime_suspend|resume callbacks Ulf Hansson
2021-06-08 9:02 ` [PATCH v2 3/3] PM: runtime: Clarify documentation when callbacks are unassigned Ulf Hansson
2021-06-08 14:23 ` Alan Stern
2021-06-08 14:30 ` Ulf Hansson
2021-06-08 14:49 ` Alan Stern
2021-06-09 9:45 ` Ulf Hansson
2021-06-08 14:24 ` [PATCH v2 0/3] PM: runtime: Update behaviour for no callbacks Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608090250.85256-1-ulf.hansson@linaro.org \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=geert+renesas@glider.be \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=saravanak@google.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®