From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2531EC47082 for ; Tue, 8 Jun 2021 13:24:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0700161249 for ; Tue, 8 Jun 2021 13:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232976AbhFHN0c (ORCPT ); Tue, 8 Jun 2021 09:26:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:58790 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232854AbhFHN01 (ORCPT ); Tue, 8 Jun 2021 09:26:27 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5CE146124B; Tue, 8 Jun 2021 13:24:33 +0000 (UTC) Date: Tue, 8 Jun 2021 09:24:31 -0400 From: Steven Rostedt To: Vincent Whitchurch Cc: Christoph Hellwig , Ingo Molnar , kernel , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] tracing: Export tracing_start() and tracing_stop() Message-ID: <20210608092431.2cad44e0@oasis.local.home> In-Reply-To: <20210608125927.GA4095@axis.com> References: <20210602080118.21627-1-vincent.whitchurch@axis.com> <20210607091432.667ff0ba@oasis.local.home> <20210608125927.GA4095@axis.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 8 Jun 2021 14:59:27 +0200 Vincent Whitchurch wrote: > Right, thanks, that's certainly much simpler. I'd only used > tracing_stop() before and never noticed that tracing_on can't be used to > restart tracing, probably because the kind of problems I used it for > usually resulted in the system needing a restart anyway to be usable. You must have been using this from the beginning, because tracing_stop() was first, but people complained that it was slow and you couldn't turn it back on. Thus "tracing_off()" was added, and documented as the "thing to use" (if you looked at the comments around them). But that was years (decade?) ago. -- Steve