mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
To: <matthias.bgg@gmail.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>, <mark-pk.tsai@mediatek.com>,
	<maz@kernel.org>, <tglx@linutronix.de>, <yj.chiang@mediatek.com>
Subject: Re: [PATCH] irqchip/irq-mst: Use ARCH_MSTARV7 as default value for MST_IRQ
Date: Wed, 9 Jun 2021 01:52:37 +0800	[thread overview]
Message-ID: <20210608175237.13596-1-mark-pk.tsai@mediatek.com> (raw)
In-Reply-To: <90e2330d-4e7b-17ed-1c63-eafdf6db89fa@gmail.com>



> On 07/06/2021 05:59, Mark-PK Tsai wrote:
> > Only TV SoCs of Mediatek products have this controller
> > which inherit from MStar TV SoCs.
> > Don't enable it by default if ARCH_MEDIATEK is selected.
> > Instead, use ARCH_MSTARV7 as default value.
> > 
> > Signed-off-by: Mark-PK Tsai <mark-pk.tsai@mediatek.com>
> > ---
> >  drivers/irqchip/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> > index 62543a4eccc0..30f578e18a11 100644
> > --- a/drivers/irqchip/Kconfig
> > +++ b/drivers/irqchip/Kconfig
> > @@ -576,7 +576,7 @@ config LOONGSON_PCH_MSI
> >  config MST_IRQ
> >  	bool "MStar Interrupt Controller"
> >  	depends on ARCH_MEDIATEK || ARCH_MSTARV7 || COMPILE_TEST
> 
> We should also delete ARCH_MEDIATEK dependency.

Actually what I want to do is decouple the MST_IRQ from
ARCH_MEDIATEK, because there are only TV SoCs have this.
But if I remove the ARCH_MEDIATEK dependency, then all the
Mediatek TV SoCs kernel have to select ARCH_MSTARV7 too.
It's kind of weird.

Though it may ask some Mediatek users about MST_IRQ,
I just change the default config to prevent that all
the Mediatek kernel include this driver by default.

What would you suggest for this?

> 
> Regards,
> Matthias
> 
> > -	default ARCH_MEDIATEK
> > +	default ARCH_MSTARV7
> >  	select IRQ_DOMAIN
> >  	select IRQ_DOMAIN_HIERARCHY
> >  	help
> > 
> 

      reply	other threads:[~2021-06-08 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  3:59 Mark-PK Tsai
2021-06-08  2:49 ` Mark-PK Tsai
2021-06-08 14:03 ` Matthias Brugger
2021-06-08 17:52   ` Mark-PK Tsai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210608175237.13596-1-mark-pk.tsai@mediatek.com \
    --to=mark-pk.tsai@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=maz@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=yj.chiang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®