From: Thierry Reding <thierry.reding@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Dmitry Osipenko <digetx@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] memory: tegra: Fixes for COMPILE_TEST
Date: Wed, 9 Jun 2021 13:28:04 +0200 [thread overview]
Message-ID: <20210609112806.3565057-1-thierry.reding@gmail.com> (raw)
From: Thierry Reding <treding@nvidia.com>
After COMPILE_TEST was enabled for the Tegra MC driver, Krzysztof
reported that this can fail to build on x86 configurations because some
dependencies are not explicitly pulled in.
Fix this by adding missing dependencies for OF_RESERVED_MEM and by
providing compile-test stubs for reset controller registration API.
Note that I was initially trying to fix the reset controller problem by
selecting RESET_CONTROLLER. This works but is discouraged because it can
create circular dependencies. And sure enough, changing that "select" to
a "depends on" triggered a circular dependency because there are already
quite a few drivers that select RESET_CONTROLLER. I suppose that's fine
as long as everybody uses "select" rather than "depends on", but it is
not a very robust solution.
Dmitry and Krzysztof were both in favour of adding the reset controller
stubs, so that's what I went with.
Thierry
Thierry Reding (2):
memory: tegra: Add missing dependencies
reset: Add compile-test stubs
drivers/memory/tegra/Kconfig | 2 ++
include/linux/reset-controller.h | 22 ++++++++++++++++++++++
2 files changed, 24 insertions(+)
--
2.31.1
next reply other threads:[~2021-06-09 11:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:28 Thierry Reding [this message]
2021-06-09 11:28 ` [PATCH 1/2] memory: tegra: Add missing dependencies Thierry Reding
2021-06-09 11:58 ` Dmitry Osipenko
2021-06-09 13:19 ` Krzysztof Kozlowski
2021-06-09 16:57 ` Dmitry Osipenko
2021-06-10 6:43 ` Krzysztof Kozlowski
2021-06-10 15:50 ` Dmitry Osipenko
2021-06-10 16:23 ` Dmitry Osipenko
2021-06-11 6:50 ` Krzysztof Kozlowski
2021-06-11 7:21 ` Dmitry Osipenko
2021-06-11 11:00 ` Thierry Reding
2021-06-11 13:40 ` Dmitry Osipenko
2021-06-14 11:50 ` Krzysztof Kozlowski
2021-06-14 14:16 ` Dmitry Osipenko
2021-06-09 17:00 ` Thierry Reding
2021-06-10 6:42 ` Krzysztof Kozlowski
2021-06-17 0:35 ` kernel test robot
2021-06-09 11:28 ` [PATCH 2/2] reset: Add compile-test stubs Thierry Reding
2021-06-09 11:47 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609112806.3565057-1-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®