From: Mark Brown <broonie@kernel.org>
To: Sander Vanheule <sander@svanheule.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Adrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support"
Date: Wed, 9 Jun 2021 14:23:02 +0100 [thread overview]
Message-ID: <20210609132302.GA9596@sirena.org.uk> (raw)
In-Reply-To: <ba7ef002d610ff5b5fc2c31411a1009587e2f068.camel@svanheule.net>
[-- Attachment #1: Type: text/plain, Size: 925 bytes --]
On Wed, Jun 09, 2021 at 02:42:06PM +0200, Sander Vanheule wrote:
> On Wed, 2021-06-09 at 13:24 +0100, Mark Brown wrote:
> > Please submit patches using subject lines reflecting the style for the
> > subsystem, this makes it easier for people to identify relevant patches.
> > Look at what existing commits in the area you're changing are doing and
> > make sure your subject lines visually resemble what they're doing.
> > There's no need to resubmit to fix this alone.
> I had grepped the commit log for other reverting patches, which also appear to
> use this style, but I didn't check the regmap-specific ones.
There's nothing in submitting-patches.rst which says to skip the usual
process for reverts - the fact that people sometimes apply things with
non-ideal subject lines doesn't mean it's best practice.
> I'll submit a v2 that fixes __regmap_init_mdio, and also applies the address
> checks to C45 access.
OK.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-06-09 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 11:46 [PATCH 0/2] Clause-22/Clause-45 MDIO regmap support fixups Sander Vanheule
2021-06-09 11:46 ` [PATCH 1/2] Revert "regmap: mdio: Add clause-45 support" Sander Vanheule
2021-06-09 12:24 ` Mark Brown
2021-06-09 12:42 ` Sander Vanheule
2021-06-09 13:23 ` Mark Brown [this message]
2021-06-09 11:46 ` [PATCH 2/2] regmap: mdio: Reject invalid clause-22 addresses Sander Vanheule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210609132302.GA9596@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sander@svanheule.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®